All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/3] arm, davinci: add support for am1808 based enbw_cmc board
Date: Tue, 29 Nov 2011 07:56:13 +0100	[thread overview]
Message-ID: <4ED4820D.9080105@denx.de> (raw)
In-Reply-To: <20111128154201.9FA7E1ADFED7@gemini.denx.de>

Hello Wolfgang,

Wolfgang Denk schrieb:
> Dear Heiko Schocher,
> 
> In message <4ED3A6A8.5010301@denx.de> you wrote:
>>>> +		ret = gpio_request(gpio, enbw_gpio_config[i].name);
>>>> +		if (ret)
>>>> +			printf("%s: Could not get %s gpio\n", __func__,
>>>> +				enbw_gpio_config[i].name);
>>>> +		else
>>> instead of having that else and adding another level of indentation below
>>> you can just add continue;
>> Done.
> 
> Is this really a good idea??

Fixed that. If there is an error, we return instead.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2011-11-29  6:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 10:44 [U-Boot] [PATCH v3 0/3] arm, davinci: add am1808 based enbw_cmc board Heiko Schocher
2011-11-28 10:44 ` [U-Boot] [PATCH v3 1/3] arm, davinci: move davinci_rtc struct to hardware.h Heiko Schocher
2011-11-28 10:44 ` [U-Boot] [PATCH v3 2/3] arm, davinci, da850: add uart1 tx rx pinmux config Heiko Schocher
2011-11-28 14:57   ` Tom Rini
2011-11-28 10:44 ` [U-Boot] [PATCH v3 3/3] arm, davinci: add support for am1808 based enbw_cmc board Heiko Schocher
2011-11-28 11:43   ` Igor Grinberg
2011-11-28 15:20     ` Heiko Schocher
2011-11-28 15:42       ` Wolfgang Denk
2011-11-29  6:56         ` Heiko Schocher [this message]
2011-11-28 15:28     ` Wolfgang Denk
2011-11-29  7:41       ` Igor Grinberg
2011-11-28 11:02 ` [U-Boot] [PATCH v3 0/3] arm, davinci: add " Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED4820D.9080105@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.