From: Christoph Egger <Christoph.Egger@amd.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 4 of 6] Add sprintf() to hvmloader
Date: Tue, 29 Nov 2011 12:11:40 +0100 [thread overview]
Message-ID: <4ED4BDEC.4010403@amd.com> (raw)
In-Reply-To: <291EDFCB1E9E224A99088639C4762022B5988E4EB6@LONPMAILBOX01.citrite.net>
On 11/29/11 12:04, Paul Durrant wrote:
>> -----Original Message-----
>> From: Christoph Egger [mailto:Christoph.Egger@amd.com]
>> Sent: 29 November 2011 11:02
>> To: Paul Durrant
>> Cc: xen-devel@lists.xensource.com
>> Subject: Re: [Xen-devel] [PATCH 4 of 6] Add sprintf() to hvmloader
>>
>> On 11/29/11 11:53, Paul Durrant wrote:
>>> # HG changeset patch
>>> # User Paul Durrant<paul.durrant@citrix.com> # Date 1322563734 0 #
>>> Node ID e9997777ab6d629b97a8b8f020c18f40c4cf3aa0
>>> # Parent 58cdfa17fb8801ab0a9e8133e0ec2ad47a426f5d
>>> Add sprintf() to hvmloader.
>>
>> For security reasons I prefer snprintf().
>>
>
> Given the limited usecase, I decided it wasn't worth it but
> I can tag on a extra patch to make the conversion if you want me to.
Yes, please. This makes new code less prone to buffer overflows
in general.
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-11-29 11:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 10:53 [PATCH 0 of 6] Add support for a VM generation ID virtual device (v2) Paul Durrant
2011-11-29 10:53 ` [PATCH 1 of 6] Add an ACPI device exposing a package called ADDR, evaluating to two Paul Durrant
2011-11-29 15:14 ` Ross Philipson
2011-11-29 16:05 ` Paul Durrant
2011-11-29 16:29 ` Ross Philipson
2011-11-29 9:19 ` Keir Fraser
2011-11-29 17:25 ` Paul Durrant
2011-11-29 11:13 ` Keir Fraser
2011-11-29 20:53 ` Ross Philipson
2011-11-29 10:53 ` [PATCH 2 of 6] Add 'ctype' infrastructure to hvmloader Paul Durrant
2011-11-29 10:53 ` [PATCH 3 of 6] Allocate an 8 byte buffer to contain the VM generation id and populate it Paul Durrant
2011-11-29 10:53 ` [PATCH 4 of 6] Add sprintf() to hvmloader Paul Durrant
2011-11-29 11:01 ` Christoph Egger
2011-11-29 11:04 ` Paul Durrant
2011-11-29 11:11 ` Christoph Egger [this message]
2011-11-29 10:53 ` [PATCH 5 of 6] Add xenstore-write support " Paul Durrant
2011-11-29 10:53 ` [PATCH 6 of 6] Add code to track the address of the VM generation id buffer across a Paul Durrant
2011-11-30 7:19 ` [PATCH 0 of 6] Add support for a VM generation ID virtual device (v2) Keir Fraser
2011-11-30 16:59 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED4BDEC.4010403@amd.com \
--to=christoph.egger@amd.com \
--cc=Paul.Durrant@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.