Hi Denis, On 27/11/2011 13:02, Denis Kenzior wrote: > Hi Guillaume, > > On 11/21/2011 04:54 AM, Guillaume Zajac wrote: >> --- >> Makefile.am | 3 +- >> drivers/cdmamodem/cdmamodem.c | 2 + >> drivers/cdmamodem/cdmamodem.h | 3 + >> drivers/cdmamodem/sim.c | 582 +++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 589 insertions(+), 1 deletions(-) >> create mode 100644 drivers/cdmamodem/sim.c >> > I really don't like us copy-pasting this much code for no good reason. > Let me toy with a few ideas, but the obvious start would be to refactor > this code into a library. Ok I will create a library to factorize the code. I will send you a first version of the library used only by AT modems. If it sounds ok I will create the CDMA sim driver using this library. Kind regards, Guillaume