From: Eric Sandeen <sandeen@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Alasdair G Kergon <agk@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Surbhi Palande <csurbhi@gmail.com>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org,
Christopher Chaltain <christopher.chaltain@canonical.com>,
Valerie Aurora <val@vaaconsulting.com>
Subject: Re: [dm-devel] [PATCH] deadlock with suspend and quotas
Date: Tue, 29 Nov 2011 10:33:46 -0600 [thread overview]
Message-ID: <4ED5096A.8060706@redhat.com> (raw)
In-Reply-To: <20111129133239.GA9926@quack.suse.cz>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/29/11 7:32 AM, Jan Kara wrote:
> On Tue 29-11-11 13:18:11, Alasdair G Kergon wrote:
>> On Tue, Nov 29, 2011 at 02:09:13PM +0100, Jan Kara wrote:
>>> Hmm, then why do these operations suspend the filesystem if they
>>> apparently don't need it? Sorry for my ignorance, I never seriously worked
>>> with LVM code...
>>
>> They don't suspend it if they don't need to.
>>
>> dm-ioctl.h:
>> /*
>> * Set this to avoid attempting to freeze any filesystem when suspending.
>> */
>> #define DM_SKIP_LOCKFS_FLAG (1 << 10) /* In */
> Thanks. I was now checking in detail and indeed FIFREEZE fails if
> ->freeze_fs is not set. And only xfs, ext3, ext4, reiserfs, jfs, nilfs2,
> and gfs2 provide this function. So I was correct in assuming that when
> filesystem supports FIFREEZE it must make sure no modifications happen to
> the filesystem. So I believe that my original plan for sync to skip frozen
> filesystem is correct.
Jan, FWIW I agree with this as well.
- -Eric
> Honza
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJO1QlpAAoJECCuFpLhPd7g3wEP/1C7T280LLZHubBMolF1dEp0
qJPQAcMUCcwMn+ewMZF5Pg/Li5WxveLNydzUWURrmnXolHddkvmoUESeJt6ugraT
i0bgb3ICRKpYi/1GEsW8UZQMXWIjdg5qyEvagDou/oy7qPXeND+JTvSYdqoti0Fn
pKv9ZUuU2arPrdDqCHP0lmiU1mF85/h/liB09GdFll3nLvSahJK5N9Cr6d0jG4VL
9faJSKI4EgVvyDPWx+L4mA5aIbPveQY0LbzpS+QSGswkd4ylVvLCV76oYj4jEH7R
hbv8OjgWTEKV8wgqmFFF/HXwzmJqzfT0rFCgbe4ZCJdnNujRe2h/wg5Gpkbj3lWc
htwUZfKKg9Vm9PheqMVxbRYEbWXB+g2Seiv/5fHNNG3WeFuPo15ftcu3Kjj7z/gS
zY1PnkHJj7/fF9tyZyTGb/AXicJyLJN7gWvf8pWNETXd4PfuDHgD70iQfWbZdKfe
0a+G4AGhXJ9zrjImM1vnsq09AMTQApL+Lm+VxdPfUbFBZd9pSC+xbBDKvOl8qy3A
Gllbjtbwi/3hV2S8t4vSLLowRTZqkLC+VHphnyLlwVeHAUsqZXQ58ZrFNx2NaYdL
UGkEty8zHGL08Yglwfd2iSlzDb/0OmCurXSZcAAXH47AAzPxZgN80KFbwc2PsGG7
DC9hxrb1bGZojdDTsuku
=UWkJ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-11-29 16:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 20:25 [PATCH] deadlock with suspend and quotas Mikulas Patocka
2011-11-28 15:04 ` Jan Kara
2011-11-28 21:00 ` Valerie Aurora
2011-11-28 21:14 ` Mikulas Patocka
2011-11-28 23:32 ` Mikulas Patocka
2011-11-28 23:32 ` Mikulas Patocka
2011-11-29 10:19 ` Jan Kara
2011-11-29 10:21 ` Jan Kara
2011-11-29 11:06 ` Mikulas Patocka
2011-11-29 11:11 ` Jan Kara
2011-11-29 12:54 ` Mikulas Patocka
2011-11-29 13:09 ` Jan Kara
2011-11-29 13:18 ` [dm-devel] " Alasdair G Kergon
2011-11-29 13:32 ` Jan Kara
2011-11-29 16:33 ` Eric Sandeen [this message]
2011-11-30 6:52 ` Mikulas Patocka
2011-11-30 11:16 ` Jan Kara
2011-11-30 12:14 ` Mikulas Patocka
2011-11-30 13:05 ` Alasdair G Kergon
2011-11-30 16:53 ` Jan Kara
2011-11-30 17:09 ` Mikulas Patocka
2011-11-30 13:33 ` Alasdair G Kergon
2011-11-30 13:48 ` Alasdair G Kergon
2011-11-30 16:36 ` Mikulas Patocka
2011-11-30 16:34 ` Mikulas Patocka
2011-12-01 0:34 ` Jan Kara
2011-11-30 14:09 ` Alasdair G Kergon
2011-11-30 16:53 ` Mikulas Patocka
2011-12-01 0:03 ` Jan Kara
2011-11-30 17:03 ` Mikulas Patocka
2011-11-29 20:00 ` Kamal Mostafa
2012-01-03 3:30 ` Al Viro
2012-01-03 18:22 ` Mikulas Patocka
2012-01-03 18:35 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED5096A.8060706@redhat.com \
--to=sandeen@redhat.com \
--cc=agk@redhat.com \
--cc=christopher.chaltain@canonical.com \
--cc=csurbhi@gmail.com \
--cc=dm-devel@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=val@vaaconsulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.