All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: admin@nixbits.org
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Daniel Mack <zonque@gmail.com>
Subject: Re: Kernel: snd-usb-audio: probe of 2-2:1.0 failed with error -5
Date: Tue, 29 Nov 2011 20:23:18 +0100	[thread overview]
Message-ID: <4ED53126.7000708@ladisch.de> (raw)
In-Reply-To: <CA+55aFwA5JxUn0_kWPt7R1zTbYHzi27gW9982RQtQEkiKRD86A@mail.gmail.com>

Linus Torvalds wrote:
> On Tue, Nov 29, 2011 at 11:09 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
>> N.A., please try the patch below.
>
> I don't think that will compile. At a minimum, there's a missing comma
> there, afaik.

Oops, indeed.  Now compile-tested:

--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -157,7 +157,13 @@
 	.bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL
 },
 {
-	USB_DEVICE(0x046d, 0x0990),
+	.match_flags = USB_DEVICE_ID_MATCH_DEVICE |
+		       USB_DEVICE_ID_MATCH_INT_CLASS |
+		       USB_DEVICE_ID_MATCH_INT_SUBCLASS,
+	.idVendor = 0x046d,
+	.idProduct = 0x0990,
+	.bInterfaceClass = USB_CLASS_AUDIO,
+	.bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
 	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
 		.vendor_name = "Logitech, Inc.",
 		.product_name = "QuickCam Pro 9000",

  reply	other threads:[~2011-11-29 19:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4ED4D58D.60109@nixbits.org>
2011-11-29 16:58 ` Kernel: snd-usb-audio: probe of 2-2:1.0 failed with error -5 Linus Torvalds
2011-11-29 17:20   ` Daniel Mack
2011-11-29 19:09     ` Clemens Ladisch
2011-11-29 19:12       ` Linus Torvalds
2011-11-29 19:23         ` Clemens Ladisch [this message]
2011-11-30  0:18     ` Nixbits Admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED53126.7000708@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=admin@nixbits.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.