Re: [PATCH 2/4] autotools.bbclass: Report the missing configure path

[Darren Hart <dvhart@linux.intel.com>]

On 11/30/2011 02:48 PM, Khem Raj wrote:
>>>> -               bbfatal "no configure script found"
>>>> +               bbfatal "no configure script found at $cfgscript"
>>>
>>> why not just do one line change something like
>>>
>>> bbfatal "configure script ${S}/configure not found"
>>
>> I prefer to use a variable when I need a value more than once. It avoids
>> future bugs where one is changed and the others were missed. As this
>> string is used 4 times, it seemed like the right call.
> 
> ok with variable still the cfgscript itself is the script and the
> message "no configure script found at $cfgscript"
> seems like $cfgscript is a location. you may want to make it
> "$cfgscript configure script not found" or something

I can see that (although I think can be argued this is correct as well -
a path with a filename is still a location). I was copying the language
used elsewhere... but from where is eluding my search at the moment. RP
has pulled these already I believe, so if the language here truly
bothers you, we can address it in a follow-on. Personally I don't think
it's really worth the trouble.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel