All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas McClendon <dmc.lists@filteredperception.org>
To: dm-devel@redhat.com
Subject: Re: DM_snapshot_cow filesystem (dmsetup create snapshot)
Date: Wed, 30 Nov 2011 17:34:25 -0600	[thread overview]
Message-ID: <4ED6BD81.4090609@filteredperception.org> (raw)
In-Reply-To: <20111130220259.GA7595@agk-dp.fab.redhat.com>

On 11/30/2011 04:03 PM, Alasdair G Kergon wrote:
> On Wed, Nov 30, 2011 at 04:48:05PM -0500, Frederick Grose wrote:
>> snapshot Invalid  does seem to prevent even read-only access.
>
> Indeed - once it's invalid, that's the end of it.
> If we didn't do that, changes to areas of the origin that hadn't already
> changed would start to appear in the 'snapshot' and the snapshot would become a
> nonsensical hybrid of the two devices containing no information about which
> parts of it got corrupted.
>
> Don't allow your snapshots to run out of space!

So wouldn't it be much better as far as the user is concerned if, the 
instant a snapshot reached capacity, it fell over into a read-only state 
(instead of being marked invalid?), such that further corruption beyond 
such plug-pulling variety could/would not occur?  If so, would it be 
straightforward to write such a patch and would it be beneficial enough 
to end upstream?

-dmc


> If you want to see what you can recover, use that code I mentioned earlier.
>
> Alasdair
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2011-11-30 23:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-29 11:19 DM_snapshot_cow filesystem (dmsetup create snapshot) Mr Dash Four
2011-10-29 20:49 ` Alasdair G Kergon
2011-11-27 22:31   ` Frederick Grose
2011-11-28  1:08     ` Douglas McClendon
2011-11-29  6:22       ` Frederick Grose
2011-11-30  2:09         ` Douglas McClendon
2011-11-30 21:48           ` Frederick Grose
2011-11-30 22:03             ` Alasdair G Kergon
2011-11-30 23:34               ` Douglas McClendon [this message]
2011-12-01 14:12                 ` Alasdair G Kergon
2011-12-01 20:18                   ` Douglas McClendon
2011-12-01 20:20                     ` Alasdair G Kergon
2011-12-01 20:26                       ` Douglas McClendon
2011-12-02  3:44                       ` Douglas McClendon
2011-12-02  8:46                         ` Alasdair G Kergon
2011-12-02 17:42                           ` Frederick Grose
2011-12-01 20:21                   ` Douglas McClendon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED6BD81.4090609@filteredperception.org \
    --to=dmc.lists@filteredperception.org \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.