From: Mike Dunn <mikedunn@newsguy.com>
To: dedekind1@gmail.com
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jamie Iles <jamie@jamieiles.com>,
Scott Branden <sbranden@broadcom.com>,
Wan ZongShun <mcuos.com@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Andres Salomon <dilinger@queued.net>,
Kyungmin Park <kyungmin.park@samsung.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Manuel Lauss <manuel.lauss@googlemail.com>,
linux-mtd@lists.infradead.org, Ralf Baechle <ralf@linux-mips.org>,
Jiandong Zheng <jdzheng@broadcom.com>,
Sukumar Ghorai <s-ghorai@ti.com>, Olof Johansson <olof@lixom.net>,
Vimal Singh <vimal.newwork@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH 1/5] mtd api changed to return bitflips on read operations
Date: Thu, 01 Dec 2011 03:06:56 -0800 [thread overview]
Message-ID: <4ED75FD0.3050704@newsguy.com> (raw)
In-Reply-To: <1322729362.2332.15.camel@koala>
On 12/01/2011 12:49 AM, Artem Bityutskiy wrote:
> Hi,
>
> thanks you, a nit-pick below.
>
> On Mon, 2011-11-28 at 17:01 -0800, Mike Dunn wrote:
>> * @datbuf: data buffer - if NULL only oob data are read/written
>> * @oobbuf: oob data buffer
>> + * @max_bitflips: for read operations, greatest number of bit errors corrected
>> + * on any one minimum i/o unit (e.g., nand page)
>> + * (value returned to caller by the driver)
>> *
> Could you please make this change in the comment: s/greatest/maximum/ -
> I find it easier to understand that way and it is more consistent with
> the variable name.
>
>
Sure. I'm a fan of clarity myself.
Thanks,
Mike
prev parent reply other threads:[~2011-12-01 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 1:01 [PATCH 1/5] mtd api changed to return bitflips on read operations Mike Dunn
2011-11-29 13:40 ` Thomas Petazzoni
2011-12-01 9:08 ` Artem Bityutskiy
2011-12-01 11:22 ` Mike Dunn
2011-12-01 11:38 ` Artem Bityutskiy
2011-12-01 12:41 ` Mike Dunn
2011-12-01 8:49 ` Artem Bityutskiy
2011-12-01 11:06 ` Mike Dunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED75FD0.3050704@newsguy.com \
--to=mikedunn@newsguy.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=computersforpeace@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=haojian.zhuang@gmail.com \
--cc=jamie@jamieiles.com \
--cc=jdzheng@broadcom.com \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-mtd@lists.infradead.org \
--cc=manuel.lauss@googlemail.com \
--cc=mcuos.com@gmail.com \
--cc=olof@lixom.net \
--cc=ralf@linux-mips.org \
--cc=robert.jarzmik@free.fr \
--cc=s-ghorai@ti.com \
--cc=sbranden@broadcom.com \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.