All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
Date: Thu, 01 Dec 2011 12:50:31 +0100	[thread overview]
Message-ID: <4ED76A07.7020301@gmail.com> (raw)
In-Reply-To: <CAGm1_kshT=7x4wjx+UX2jyU8M0kmRt4xdhY+0YctioFzg_1FRw@mail.gmail.com>

On 11/30/2011 10:31 PM, Yegor Yefremov wrote:
> Hi Daniel,
> 
>>>> The CFLAGS have to be augmented for the include dir and the patch
>>>> needs to be tweaked to make the binary link to libnl-3 instead of
>>>> libnl-gen.
>>>>
>>>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>>>> ---
>>>>  package/iw/iw-libnl-30-support.patch |    2 +-
>>>>  package/iw/iw.mk                     |    2 +-
>>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/package/iw/iw-libnl-30-support.patch b/package/iw/iw-libnl-30-support.patch
>>>
>>> this file has gone in next. Please rebase your patches on the next
>>
>> I can do this. I wasn't even aware of this branch, and part of the
>> reason is that it doesn't show up on the cgit web interface
>> (http://git.buildroot.net/buildroot) when there's no trailing slash in
>> the URI, which is unfortunately the location the website
>> (http://buildroot.uclibc.org/git.html) points visitors to. You can click
>> on "refs" and back on "summary" which will add the "/" suffix, and then
>> cgit will show the existance of the "next" branch. Very odd.
>>
>>> branch and try to get iw from git with this commit
>>> http://git.sipsolutions.net/?p=iw.git;a=commit;h=a82abc2cac9dea7def53070565201145c76c8c6c.
>>
>> Not sure whether I follow you here. Do you suggest writing package
>> definitions for sources that are not released yet officially? If that is
>> the case, what is the reason?
> 
> I see here 3 possibilities:
> 
> 1. replace official release with git one
> 2. wait for iw 3.3
> 3. apply related patches (from iw repo) only
> 
> the first way is simpler and quicker to implement

Ok, fine. I did that and the git version seems to cope well with
nibnl-3. Nice.

>> Also, I fail to see how the commit you pointed me to is related to the
>> changed location of libnl-3. Is this not something that should be
>> addressed independently?
> 
> I just pointed to the latest commit. You can choose the one with related changes

Ok. I rebased all patches and will repost them all. Thanks for your review!


Dainel

  reply	other threads:[~2011-12-01 11:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 16:27 [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack
2011-11-29 18:16 ` [Buildroot] [PATCH] hostapd: fix build with new libnl-3 Daniel Mack
2011-11-29 18:27   ` Daniel Mack
2011-11-29 18:24 ` [Buildroot] [PATCH] wpa_supplicant: " Daniel Mack
2011-11-29 21:26 ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Yegor Yefremov
2011-11-29 21:28   ` Yegor Yefremov
2011-11-30 15:05     ` [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3 Daniel Mack
2011-11-30 15:06       ` [Buildroot] [PATCH 2/2] kismet: " Daniel Mack
2011-11-30 15:54       ` [Buildroot] [PATCH 1/2] iw: " Yegor Yefremov
2011-11-30 16:31         ` Daniel Mack
2011-11-30 16:36           ` Michael S. Zick
2011-11-30 16:41             ` Michael S. Zick
2011-11-30 21:31           ` Yegor Yefremov
2011-12-01 11:50             ` Daniel Mack [this message]
2011-12-24 15:24           ` Peter Korsgaard
2011-12-24 15:56             ` Stephan Hoffmann
2011-11-30 15:06     ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED76A07.7020301@gmail.com \
    --to=zonque@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.