Re: [Qemu-devel] [PATCH 17/18] Add test tools

[Anthony Liguori <anthony@codemonkey.ws>]

On 12/01/2011 05:26 AM, Stefan Hajnoczi wrote:
> On Wed, Nov 30, 2011 at 03:03:47PM -0600, Anthony Liguori wrote:
>> diff --git a/QMP/qom-get b/QMP/qom-get
>> new file mode 100755
>> index 0000000..b086bc5
>> --- /dev/null
>> +++ b/QMP/qom-get
>> @@ -0,0 +1,26 @@
>> +#!/usr/bin/python
>> +##
>> +# Virtio Support
>
> QEMU Object Model property getter utility
>
>> +#
>> +# Copyright IBM, Corp. 2011
>> +#
>> +# Authors:
>> +#  Anthony Liguori<aliguori@us.ibm.com>
>> +#
>> +# This work is licensed under the terms of the GNU GPL, version 2 or later.  See
>> +# the COPYING file in the top-level directory.
>> +##
>> +
>> +import sys
>> +from qmp import QEMUMonitorProtocol
>> +
>> +srv = QEMUMonitorProtocol('/tmp/server.sock')
>
> I think it would be worth doing it like QMP/qmp-shell.py and using a
> command-line argument.  We might also like to support a
> QEMU_MONITOR environment variable.
>
> Hardcoding to /tmp/server.sock makes this script less useful.
>
>> diff --git a/QMP/qom-list b/QMP/qom-list
>> new file mode 100755
>> index 0000000..5dbb07b
>> --- /dev/null
>> +++ b/QMP/qom-list
>> @@ -0,0 +1,30 @@
>> +#!/usr/bin/python
>> +##
>> +# Virtio Support
>
> QEMU Object Model property listing utility
>
>> diff --git a/QMP/qom-set b/QMP/qom-set
>> new file mode 100755
>> index 0000000..83a4394
>> --- /dev/null
>> +++ b/QMP/qom-set
>> @@ -0,0 +1,21 @@
>> +#!/usr/bin/python
>> +##
>> +# Virtio Support
>
> QEMU Object Model property setter utility


Ack.  I made these changes actually but something got lost when I sent the 
patches out.  I actually used git-publish for the first time and apparently 
screwed something up when setting up the branch :-/

Regards,

Anthony Liguori
>