All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fw_env.h: added a few missing defines
Date: Thu, 01 Dec 2011 16:21:09 +0100	[thread overview]
Message-ID: <4ED79B65.7090200@gmail.com> (raw)
In-Reply-To: <1322746204-4393-1-git-send-email-fransmeulenbroeks@gmail.com>

Dear Frans Meulenbroeks,

Am 01.12.2011 14:30, schrieb Frans Meulenbroeks:
> The README file lists 4 defined that were not actually present in the .h
> file but that were needed to get things working with settings compiled in.
> They are
> Added these to the .h file
> (the values above are the ones from the README file)
> 
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

I tend to NAK this.

> ---
>  tools/env/fw_env.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/tools/env/fw_env.h b/tools/env/fw_env.h
> index 9258c79..2dcb373 100644
> --- a/tools/env/fw_env.h
> +++ b/tools/env/fw_env.h
> @@ -34,8 +34,12 @@
>  #define DEVICE2_NAME      "/dev/mtd2"
>  #define DEVICE1_OFFSET    0x0000
>  #define ENV1_SIZE         0x4000
> +#define DEVICE1_ESIZE     0x4000
> +#define DEVICE1_ENVSECTORS     2

This change will overwrite the settings done by ENV1_SIZE ... and none
of the settings match my boards needs ;)

I would appreciate you test my patch
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/106972/focus=112948
or http://patchwork.ozlabs.org/patch/120372/

I guess you could fulfil your requirements with that patch too.

best regards

Andreas Bie?mann

  reply	other threads:[~2011-12-01 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 13:30 [U-Boot] [PATCH] fw_env.h: added a few missing defines Frans Meulenbroeks
2011-12-01 15:21 ` Andreas Bießmann [this message]
2011-12-02  8:24   ` Frans Meulenbroeks
2011-12-02 10:13     ` Andreas Bießmann
  -- strict thread matches above, loose matches on Subject: below --
2012-01-02 13:47 Frans Meulenbroeks
2012-01-05 15:07 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED79B65.7090200@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.