From: Heiko Schocher <hs@denx.de>
To: juha.kuikka@gmail.com
Cc: "Rajashekhara, Sudhakar" <sudhakar.raj@ti.com>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
Wolfgang Denk <wd@denx.de>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Jarkko Lavinen <jarkko.lavinen@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Vipin Bhandari <vipin.bhandari@ti.com>,
"Kumar, Purushotam" <purushotam@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: arm, am1808: using mmc1 controller and dma
Date: Fri, 02 Dec 2011 10:19:57 +0100 [thread overview]
Message-ID: <4ED8983D.5020400@denx.de> (raw)
In-Reply-To: <B6A220404B6BFC4BBD2AB91C54D39DF4029429@DBDE01.ent.ti.com>
Hello Juha,
Rajashekhara, Sudhakar wrote:
> Hi,
>
> On Fri, Dec 02, 2011 at 14:25:48, Heiko Schocher wrote:
>> Hello Rajashekhara, Sudhakar,
>>
>> Rajashekhara, Sudhakar wrote:
>>> Hi,
>>>
>>> On Fri, Dec 02, 2011 at 13:05:22, Heiko Schocher wrote:
>>>> Hello,
>>>>
>>>> trying Linux 3.2.0-rc3 on an am1808 based board using MMCSD1 controller,
>>>> and facing problems with using DMA. Deactivating use_dma=0 in the
>>>> davinci_mmc controller and mmc works in pio mode without problems.
>>>> So there are no hardware problems, pinmux is ok, psc are all on.
>>>>
>>> Please refer to the discussion at [1] where similar issue was discussed. Go through the
>
> [...]
>
>> Yuhu! that works for me! But I had to fix it a little, because "edma_info"
>> is now named "info". Here my diff:
>>
>
> Yup, this patch was on an older version.
>
>> diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
>> index da90103..e10a251 100644
>> --- a/arch/arm/mach-davinci/dma.c
>> +++ b/arch/arm/mach-davinci/dma.c
>> @@ -1513,7 +1513,7 @@ static int __init edma_probe(struct platform_device *pdev)
>> * started by the codec engine will not cause audio defects.
>> */
>> for (i = 0; i < edma_cc[j]->num_channels; i++)
>> - map_dmach_queue(j, i, EVENTQ_1);
>> + map_dmach_queue(j, i, info[j]->default_queue);
>>
>> queue_tc_mapping = info[j]->queue_tc_mapping;
>> queue_priority_mapping = info[j]->queue_priority_mapping;
>>
>>> [1] http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg17926.html
>> Do you prepare a patch, or should I send it?
>>
>
> You can go ahead and submit the patch but Juha was the person who found out this issue.
Juha, can you post this patch, or is it ok for you, if I post it
with your "Reported-by" and "Signed-off-by"?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2011-12-02 9:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 7:35 arm, am1808: using mmc1 controller and dma Heiko Schocher
2011-12-02 8:34 ` Rajashekhara, Sudhakar
2011-12-02 8:55 ` Heiko Schocher
2011-12-02 9:00 ` Rajashekhara, Sudhakar
2011-12-02 9:19 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED8983D.5020400@denx.de \
--to=hs@denx.de \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=jarkko.lavinen@nokia.com \
--cc=juha.kuikka@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=purushotam@ti.com \
--cc=sudhakar.raj@ti.com \
--cc=vipin.bhandari@ti.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.