From: Tabi Timur-B04825 <B04825@freescale.com>
To: "broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@ti.com" <lrg@ti.com>
Subject: Re: [PATCH 2/2] ASoC: fsl/powerpc: don't rely on the cell-index property
Date: Fri, 2 Dec 2011 12:14:44 +0000 [thread overview]
Message-ID: <4ED8C133.2080908@freescale.com> (raw)
In-Reply-To: <1322790767-25846-2-git-send-email-timur@freescale.com>
Timur Tabi wrote:
> Instead of using the 'cell-index' property in the I2C adapter node to
> determine the adapter number, just query the i2c_adapter object directly.
>
> Previously, the I2C nodes always appeared in cell-index order, so the
> dynamic numbering coincided with the cell-index property. With commit
> ab827d97 ("powerpc/85xx: Rework P1022DS device tree"), the I2C nodes are
> unintentionally reversed in the device tree, and so the machine driver
> guesses the wrong I2C adapter number.
>
> Signed-off-by: Timur Tabi<timur@freescale.com>
Mark,
Can you hold off on applying patch #2 for the moment? I just thought of
something that I want to try first.
Patch #1 is good to go, though.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-12-02 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 1:52 [PATCH 1/2] ASoC: p1022ds: add support for fsl, P1022 and fsl, P1022DS model names Timur Tabi
2011-12-02 1:52 ` [PATCH 2/2] ASoC: fsl/powerpc: don't rely on the cell-index property Timur Tabi
2011-12-02 12:14 ` Tabi Timur-B04825 [this message]
2011-12-02 12:18 ` Mark Brown
2011-12-02 12:20 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED8C133.2080908@freescale.com \
--to=b04825@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.