From: Felix Fietkau <nbd@openwrt.org>
To: Nikolay Martynov <mar.kolya@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 3/4] ath9k: use config.enable_ani to check if ani should be performed
Date: Fri, 02 Dec 2011 17:40:42 +0100 [thread overview]
Message-ID: <4ED8FF8A.503@openwrt.org> (raw)
In-Reply-To: <CALGY4fuiQ5k3yq9UtPVfLRaoDj-4Ui8vThnDnprsCoZNdPcOZw@mail.gmail.com>
On 2011-12-02 4:22 PM, Nikolay Martynov wrote:
> 2011/12/2 Felix Fietkau <nbd@openwrt.org>:
>> On 2011-11-30 9:46 PM, Nikolay Martynov wrote:
>>> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
>>> index 0b9a0e8..391d59c 100644
>>> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
>>> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
>>> @@ -808,7 +808,8 @@ void ath9k_htc_ani_work(struct work_struct *work)
>>> }
>>>
>>> /* Verify whether we must check ANI */
>>> - if ((timestamp - common->ani.checkani_timer) >= ATH_ANI_POLLINTERVAL) {
>>> + if (sc->sc_ah->config.enable_ani &&
>>> + (timestamp - common->ani.checkani_timer) >= ATH_ANI_POLLINTERVAL) {
>>> aniflag = true;
>>> common->ani.checkani_timer = timestamp;
>>> }
>> Does not compile, there is no 'sc' variable, use ah->config.enable_ani.
>
> Hmm... weird that it didn't fail when I applied this to openwrt.
> Anyway, thanks for letting me know, I'll send an updated patch!
Maybe you didn't enable kmod-ath9k-htc - if that one's disabled, it does
not build this source file.
- Felix
next prev parent reply other threads:[~2011-12-02 16:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 0:22 [ath9k-devel] [PATCH v2 0/4] Fix the way ANI is being handled for ar9100 and ar9340 Nikolay Martynov
2011-11-28 0:22 ` Nikolay Martynov
2011-11-28 0:22 ` [ath9k-devel] [PATCH v2 1/4] ath9k: trivial: cosmetic fix in calibration debug log Nikolay Martynov
2011-11-28 0:22 ` Nikolay Martynov
2011-11-28 2:52 ` [ath9k-devel] " Julian Calaby
2011-11-28 2:52 ` Julian Calaby
2011-11-28 3:49 ` [ath9k-devel] " Nikolay Martynov
2011-11-28 3:49 ` Nikolay Martynov
2011-11-28 3:51 ` [ath9k-devel] [PATCH v3] " Nikolay Martynov
2011-11-28 3:51 ` Nikolay Martynov
2011-11-28 0:22 ` [ath9k-devel] [PATCH v2 2/4] ath9k: change calibration debug log to output all calibration types Nikolay Martynov
2011-11-28 0:22 ` Nikolay Martynov
2011-11-28 0:22 ` [ath9k-devel] [PATCH v2 3/4] ath9k: use config.enable_ani to check if ani should be performed Nikolay Martynov
2011-11-28 0:22 ` Nikolay Martynov
2011-11-28 0:22 ` [ath9k-devel] [PATCH v2 4/4] ath9k: enable ANI for ar9100 chips Nikolay Martynov
2011-11-28 0:22 ` Nikolay Martynov
2011-11-28 1:09 ` [ath9k-devel] [PATCH v2 0/4] Fix the way ANI is being handled for ar9100 and ar9340 Adrian Chadd
2011-11-28 1:09 ` Adrian Chadd
2011-11-28 1:18 ` [ath9k-devel] " Adrian Chadd
2011-11-28 1:18 ` Adrian Chadd
2011-11-28 2:35 ` [ath9k-devel] " Nikolay Martynov
2011-11-28 2:35 ` Nikolay Martynov
2011-11-30 20:10 ` [ath9k-devel] " John W. Linville
2011-11-30 20:10 ` John W. Linville
2011-11-30 20:46 ` [PATCH v3 " Nikolay Martynov
2011-11-30 20:46 ` [PATCH v3 1/4] ath9k: trivial: cosmetic fix in calibration debug log Nikolay Martynov
2011-11-30 20:46 ` [PATCH v3 2/4] ath9k: change calibration debug log to output all calibration types Nikolay Martynov
2011-11-30 20:46 ` [PATCH v3 3/4] ath9k: use config.enable_ani to check if ani should be performed Nikolay Martynov
2011-12-02 11:04 ` Felix Fietkau
2011-12-02 15:22 ` Nikolay Martynov
2011-12-02 16:40 ` Felix Fietkau [this message]
2011-11-30 20:46 ` [PATCH v3 4/4] ath9k: enable ANI for ar9100 chips Nikolay Martynov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED8FF8A.503@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mar.kolya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.