From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v7 00/10] Request for Inclusion: per-cgroup tcp memory pressure Date: Fri, 2 Dec 2011 16:04:08 -0200 Message-ID: <4ED91318.1030803@parallels.com> References: <1322611021-1730-1-git-send-email-glommer@parallels.com> <20111130111152.6b1c7366.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111130111152.6b1c7366.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: KAMEZAWA Hiroyuki Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org, lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org, avagin-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 11/30/2011 12:11 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 29 Nov 2011 21:56:51 -0200 > Glauber Costa wrote: > >> Hi, >> >> This patchset implements per-cgroup tcp memory pressure controls. It did not change >> significantly since last submission: rather, it just merges the comments Kame had. >> Most of them are style-related and/or Documentation, but there are two real bugs he >> managed to spot (thanks) >> >> Please let me know if there is anything else I should address. >> > > After reading all codes again, I feel some strange. Could you clarify ? > > Here. > == > +void sock_update_memcg(struct sock *sk) > +{ > + /* right now a socket spends its whole life in the same cgroup */ > + if (sk->sk_cgrp) { > + WARN_ON(1); > + return; > + } > + if (static_branch(&memcg_socket_limit_enabled)) { > + struct mem_cgroup *memcg; > + > + BUG_ON(!sk->sk_prot->proto_cgroup); > + > + rcu_read_lock(); > + memcg = mem_cgroup_from_task(current); > + if (!mem_cgroup_is_root(memcg)) > + sk->sk_cgrp = sk->sk_prot->proto_cgroup(memcg); > + rcu_read_unlock(); > == > > sk->sk_cgrp is set to a memcg without any reference count. > > Then, no check for preventing rmdir() and freeing memcgroup. > > Is there some css_get() or mem_cgroup_get() somewhere ? > There were a css_get in the first version of this patchset. It was removed, however, because it was deemed anti-intuitive to prevent rmdir, since we can't know which sockets are blocking it, or do anything about it. Or did I misunderstand something ? -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 6E3066B004D for ; Fri, 2 Dec 2011 13:04:47 -0500 (EST) Message-ID: <4ED91318.1030803@parallels.com> Date: Fri, 2 Dec 2011 16:04:08 -0200 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v7 00/10] Request for Inclusion: per-cgroup tcp memory pressure References: <1322611021-1730-1-git-send-email-glommer@parallels.com> <20111130111152.6b1c7366.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20111130111152.6b1c7366.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net, gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, kirill@shutemov.name, avagin@parallels.com, devel@openvz.org, eric.dumazet@gmail.com, cgroups@vger.kernel.org On 11/30/2011 12:11 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 29 Nov 2011 21:56:51 -0200 > Glauber Costa wrote: > >> Hi, >> >> This patchset implements per-cgroup tcp memory pressure controls. It did not change >> significantly since last submission: rather, it just merges the comments Kame had. >> Most of them are style-related and/or Documentation, but there are two real bugs he >> managed to spot (thanks) >> >> Please let me know if there is anything else I should address. >> > > After reading all codes again, I feel some strange. Could you clarify ? > > Here. > == > +void sock_update_memcg(struct sock *sk) > +{ > + /* right now a socket spends its whole life in the same cgroup */ > + if (sk->sk_cgrp) { > + WARN_ON(1); > + return; > + } > + if (static_branch(&memcg_socket_limit_enabled)) { > + struct mem_cgroup *memcg; > + > + BUG_ON(!sk->sk_prot->proto_cgroup); > + > + rcu_read_lock(); > + memcg = mem_cgroup_from_task(current); > + if (!mem_cgroup_is_root(memcg)) > + sk->sk_cgrp = sk->sk_prot->proto_cgroup(memcg); > + rcu_read_unlock(); > == > > sk->sk_cgrp is set to a memcg without any reference count. > > Then, no check for preventing rmdir() and freeing memcgroup. > > Is there some css_get() or mem_cgroup_get() somewhere ? > There were a css_get in the first version of this patchset. It was removed, however, because it was deemed anti-intuitive to prevent rmdir, since we can't know which sockets are blocking it, or do anything about it. Or did I misunderstand something ? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932114Ab1LBSEs (ORCPT ); Fri, 2 Dec 2011 13:04:48 -0500 Received: from mx2.parallels.com ([64.131.90.16]:59178 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168Ab1LBSEr (ORCPT ); Fri, 2 Dec 2011 13:04:47 -0500 Message-ID: <4ED91318.1030803@parallels.com> Date: Fri, 2 Dec 2011 16:04:08 -0200 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: , , , , , , , , , , , , Subject: Re: [PATCH v7 00/10] Request for Inclusion: per-cgroup tcp memory pressure References: <1322611021-1730-1-git-send-email-glommer@parallels.com> <20111130111152.6b1c7366.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20111130111152.6b1c7366.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [201.82.130.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/2011 12:11 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 29 Nov 2011 21:56:51 -0200 > Glauber Costa wrote: > >> Hi, >> >> This patchset implements per-cgroup tcp memory pressure controls. It did not change >> significantly since last submission: rather, it just merges the comments Kame had. >> Most of them are style-related and/or Documentation, but there are two real bugs he >> managed to spot (thanks) >> >> Please let me know if there is anything else I should address. >> > > After reading all codes again, I feel some strange. Could you clarify ? > > Here. > == > +void sock_update_memcg(struct sock *sk) > +{ > + /* right now a socket spends its whole life in the same cgroup */ > + if (sk->sk_cgrp) { > + WARN_ON(1); > + return; > + } > + if (static_branch(&memcg_socket_limit_enabled)) { > + struct mem_cgroup *memcg; > + > + BUG_ON(!sk->sk_prot->proto_cgroup); > + > + rcu_read_lock(); > + memcg = mem_cgroup_from_task(current); > + if (!mem_cgroup_is_root(memcg)) > + sk->sk_cgrp = sk->sk_prot->proto_cgroup(memcg); > + rcu_read_unlock(); > == > > sk->sk_cgrp is set to a memcg without any reference count. > > Then, no check for preventing rmdir() and freeing memcgroup. > > Is there some css_get() or mem_cgroup_get() somewhere ? > There were a css_get in the first version of this patchset. It was removed, however, because it was deemed anti-intuitive to prevent rmdir, since we can't know which sockets are blocking it, or do anything about it. Or did I misunderstand something ? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v7 00/10] Request for Inclusion: per-cgroup tcp memory pressure Date: Fri, 2 Dec 2011 16:04:08 -0200 Message-ID: <4ED91318.1030803@parallels.com> References: <1322611021-1730-1-git-send-email-glommer@parallels.com> <20111130111152.6b1c7366.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , , , , , , , , , , To: KAMEZAWA Hiroyuki Return-path: In-Reply-To: <20111130111152.6b1c7366.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 11/30/2011 12:11 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 29 Nov 2011 21:56:51 -0200 > Glauber Costa wrote: > >> Hi, >> >> This patchset implements per-cgroup tcp memory pressure controls. It did not change >> significantly since last submission: rather, it just merges the comments Kame had. >> Most of them are style-related and/or Documentation, but there are two real bugs he >> managed to spot (thanks) >> >> Please let me know if there is anything else I should address. >> > > After reading all codes again, I feel some strange. Could you clarify ? > > Here. > == > +void sock_update_memcg(struct sock *sk) > +{ > + /* right now a socket spends its whole life in the same cgroup */ > + if (sk->sk_cgrp) { > + WARN_ON(1); > + return; > + } > + if (static_branch(&memcg_socket_limit_enabled)) { > + struct mem_cgroup *memcg; > + > + BUG_ON(!sk->sk_prot->proto_cgroup); > + > + rcu_read_lock(); > + memcg = mem_cgroup_from_task(current); > + if (!mem_cgroup_is_root(memcg)) > + sk->sk_cgrp = sk->sk_prot->proto_cgroup(memcg); > + rcu_read_unlock(); > == > > sk->sk_cgrp is set to a memcg without any reference count. > > Then, no check for preventing rmdir() and freeing memcgroup. > > Is there some css_get() or mem_cgroup_get() somewhere ? > There were a css_get in the first version of this patchset. It was removed, however, because it was deemed anti-intuitive to prevent rmdir, since we can't know which sockets are blocking it, or do anything about it. Or did I misunderstand something ? -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html