From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 4/6] arm, da850evm: Add an SPL for SPI boot
Date: Fri, 2 Dec 2011 13:07:22 -0700 [thread overview]
Message-ID: <4ED92FFA.3080701@ti.com> (raw)
In-Reply-To: <1322842330-25213-5-git-send-email-christian.riesch@omicron.at>
On 12/02/2011 09:12 AM, Christian Riesch wrote:
[snip]
> include/configs/da850evm.h | 87 +++++++++++++++++++++++++++++++++
[snip]
> +#define CONFIG_SYS_DA850_DDR2_SDTIMR (0 | \
> + (14 << DV_DDR_SDTMR1_RFC_SHIFT) | \
> + (2 << DV_DDR_SDTMR1_RP_SHIFT) | \
> + (2 << DV_DDR_SDTMR1_RCD_SHIFT) | \
> + (1 << DV_DDR_SDTMR1_WR_SHIFT) | \
> + (5 << DV_DDR_SDTMR1_RAS_SHIFT) | \
> + (8 << DV_DDR_SDTMR1_RC_SHIFT) | \
> + (1 << DV_DDR_SDTMR1_RRD_SHIFT) | \
> + (0 << DV_DDR_SDTMR1_WTR_SHIFT))
'0 | ..' and '0 << ...' don't help readability over just value saying it
(same with shifting 0). Also, unless the manual these come from uses
decimal here, hex is preferred. Thanks!
--
Tom
next prev parent reply other threads:[~2011-12-02 20:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 16:12 [U-Boot] [PATCH v4 0/6] Add an SPL to boot the da850evm from SPI Christian Riesch
2011-12-02 16:12 ` [U-Boot] [PATCH v4 1/6] spl: display_options.o is required for SPI flash support in SPL Christian Riesch
2011-12-02 16:12 ` [U-Boot] [PATCH v4 2/6] sf: Add spi_boot() to allow booting from SPI flash in an SPL Christian Riesch
2011-12-02 21:23 ` Mike Frysinger
2011-12-02 16:12 ` [U-Boot] [PATCH v4 3/6] arm, davinci: Add SPL support for DA850 SoCs Christian Riesch
2011-12-02 20:09 ` Tom Rini
2011-12-02 16:12 ` [U-Boot] [PATCH v4 4/6] arm, da850evm: Add an SPL for SPI boot Christian Riesch
2011-12-02 20:07 ` Tom Rini [this message]
2011-12-03 5:49 ` [U-Boot] [PATCH v3 13/15] " Christian Riesch
2011-12-03 14:55 ` Tom Rini
2011-12-05 10:20 ` Christian Riesch
2011-12-05 14:46 ` Tom Rini
2011-12-02 16:12 ` [U-Boot] [PATCH v4 5/6] mkimage: Fix variable length header support Christian Riesch
2011-12-02 16:12 ` [U-Boot] [PATCH v4 6/6] arm, davinci: Add support for generating AIS images to the Makefile Christian Riesch
2011-12-02 21:24 ` Mike Frysinger
2011-12-03 5:20 ` Christian Riesch
2011-12-03 7:08 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED92FFA.3080701@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.