All of lore.kernel.org
 help / color / mirror / Atom feed
From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix some bugs in the EFI support
Date: Sat, 03 Dec 2011 08:28:39 +1100	[thread overview]
Message-ID: <4ED94307.2030604@gmail.com> (raw)
In-Reply-To: <1322609941-31147-1-git-send-email-gabeblack@chromium.org>

Hi Anton,

On 30/11/11 10:39, Gabe Black wrote:
> The ALLOC_CACHE_ALIGN_BUFFER macro allocates a pointer to a buffer, and the
> address of the pointer and not the buffer was being passed to a function
> that expected the other. This change fixes a few places that bug crops up.
> Also, it provides a default definition for the CONFIG_SYS_CACHELINE_SIZE
> macro to avoid compiler errors.
> 
> Signed-off-by: Gabe Black <gabeblack@chromium.org>
> ---
>  disk/part_efi.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/disk/part_efi.c b/disk/part_efi.c
> index e7f2714..c94d808 100644
> --- a/disk/part_efi.c
> +++ b/disk/part_efi.c
> @@ -37,6 +37,10 @@
>  #include "part_efi.h"
>  #include <linux/ctype.h>
>  
> +#ifndef CONFIG_SYS_CACHELINE_SIZE
> +#define CONFIG_SYS_CACHELINE_SIZE __BIGGEST_ALIGNMENT__
> +#endif
> +
>  #if defined(CONFIG_CMD_IDE) || \
>      defined(CONFIG_CMD_MG_DISK) || \
>      defined(CONFIG_CMD_SATA) || \
> @@ -130,7 +134,7 @@ void print_part_efi(block_dev_desc_t * dev_desc)
>  	}
>  	/* This function validates AND fills in the GPT header and PTE */
>  	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
> -			 &(gpt_head), &gpt_pte) != 1) {
> +			 gpt_head, &gpt_pte) != 1) {
>  		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
>  		return;
>  	}
> @@ -169,7 +173,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, int part,
>  
>  	/* This function validates AND fills in the GPT header and PTE */
>  	if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA,
> -			&(gpt_head), &gpt_pte) != 1) {
> +			gpt_head, &gpt_pte) != 1) {
>  		printf("%s: *** ERROR: Invalid GPT ***\n", __func__);
>  		return -1;
>  	}

This appears to be a fix for your "part_efi: dcache: allocate cacheline
aligned buffers" commit - Can you have a look at it please? If you ack, I
will apply to staging

Regards,

Graeme

  reply	other threads:[~2011-12-02 21:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 23:39 [U-Boot] [PATCH] Fix some bugs in the EFI support Gabe Black
2011-12-02 21:28 ` Graeme Russ [this message]
2011-12-02 21:59   ` Simon Glass
2011-12-06 18:50     ` Anton Staaf
2011-12-06 19:22       ` Anatolij Gustschin
2011-12-06 19:35       ` Wolfgang Denk
2011-12-09 23:20         ` Anton Staaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED94307.2030604@gmail.com \
    --to=graeme.russ@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.