From: "Martin Hundebøll" <martin@hundeboll.net>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Move is_out_of_time() to main.c for general use
Date: Sat, 03 Dec 2011 16:54:09 +0100 [thread overview]
Message-ID: <4EDA4621.905@hundeboll.net> (raw)
In-Reply-To: <201112032346.52327.lindner_marek@yahoo.de>
On 2011-12-03 16:46, Marek Lindner wrote:
> On Saturday, December 03, 2011 23:41:38 Martin Hundebøll wrote:
>> On 2011-12-03 08:36, Marek Lindner wrote:
>>> Since it is a simple one-liner you could make it a define or at least
>>> static inline (in main.h).
>>
>> Correct. Maybe the correct solution is to remove the function and just call
>> time_is_before_jiffies() directly instead?
>
> Guess you misread me. I like the idea of having this easy to read wrapper.
> Before you moved it to main.c it was a static function. The compiler could
> better optimize it.
OK. Didn't misread you; just tried to think :) I'll send a patch with moving it to an inline function in main.h.
--
Kind regards
Martin Hundebøll
+45 61 65 54 61
martin@hundeboll.net
Nordborggade 57, 2. tv
8000 Aarhus C
Denmark
next prev parent reply other threads:[~2011-12-03 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 14:15 [B.A.T.M.A.N.] [PATCH] batman-adv: Move is_out_of_time() to main.c for general use Martin Hundebøll
2011-12-02 14:37 ` Martin Hundebøll
2011-12-03 7:36 ` Marek Lindner
2011-12-03 15:41 ` Martin Hundebøll
2011-12-03 15:46 ` Marek Lindner
2011-12-03 15:54 ` Martin Hundebøll [this message]
2011-12-08 12:32 ` [B.A.T.M.A.N.] [PATCHv2] batman-adv: Move is_out_of_time() to main.h " Martin Hundebøll
2011-12-10 9:28 ` Marek Lindner
2011-12-02 14:39 ` [B.A.T.M.A.N.] [PATCH] batman-adv: Rm trailing whitespace from is_my_mac() in main.c Martin Hundebøll
2011-12-03 7:27 ` Marek Lindner
2011-12-03 15:39 ` Martin Hundebøll
2011-12-08 11:48 ` [B.A.T.M.A.N.] [PATCHv2] batman-adv: Rm empty line " Martin Hundebøll
2011-12-10 9:18 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDA4621.905@hundeboll.net \
--to=martin@hundeboll.net \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.