From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder Date: Sun, 04 Dec 2011 11:46:14 +0100 Message-ID: <4EDB4F76.30604@web.de> References: <4EDA71B5.1060006@suse.de> <4EDAA3C7.7060409@web.de> <4EDB4ED6.8030707@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5D4AF239C4829369DB6D03DF" Cc: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Marcelo Tosatti , Blue Swirl , Anthony Liguori , qemu-devel , kvm@vger.kernel.org, "Michael S. Tsirkin" To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:36825 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222Ab1LDKqT (ORCPT ); Sun, 4 Dec 2011 05:46:19 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate02.web.de (Postfix) with ESMTP id 1268D1BB1E1F4 for ; Sun, 4 Dec 2011 11:46:18 +0100 (CET) In-Reply-To: <4EDB4ED6.8030707@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5D4AF239C4829369DB6D03DF Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-12-04 11:43, Avi Kivity wrote: > On 12/04/2011 12:33 AM, Jan Kiszka wrote: >> Do we have a convention that every include in <> is considered system >> header? Should probably be documented then (and code should be convert= ed >> gradually). >=20 > It's documented in "The C Programming Language", by K&R. It's just a convention, nothing more. If you consider certain parts of QEMU's API as system (e.g. the parts that may once make our modular API), it makes some sense to use <> for. Right now this happens for some parts of the hw API. But inconsistently. Jan --------------enig5D4AF239C4829369DB6D03DF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7bT3YACgkQitSsb3rl5xRHMgCgzU0UFxI9NzrrqKBqhXVjIzaA p6sAoOE2meZ3sgcag87vfCz1FtWitHF0 =XoF+ -----END PGP SIGNATURE----- --------------enig5D4AF239C4829369DB6D03DF-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RX9aO-0002vl-NG for qemu-devel@nongnu.org; Sun, 04 Dec 2011 05:46:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RX9aN-0005NL-Hd for qemu-devel@nongnu.org; Sun, 04 Dec 2011 05:46:20 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:36820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RX9aN-0005NH-5B for qemu-devel@nongnu.org; Sun, 04 Dec 2011 05:46:19 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate02.web.de (Postfix) with ESMTP id 0F1E61BB1E1C6 for ; Sun, 4 Dec 2011 11:46:18 +0100 (CET) Message-ID: <4EDB4F76.30604@web.de> Date: Sun, 04 Dec 2011 11:46:14 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4EDA71B5.1060006@suse.de> <4EDAA3C7.7060409@web.de> <4EDB4ED6.8030707@redhat.com> In-Reply-To: <4EDB4ED6.8030707@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5D4AF239C4829369DB6D03DF" Subject: Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl , =?ISO-8859-15?Q?Andreas_F=E4rber?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5D4AF239C4829369DB6D03DF Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-12-04 11:43, Avi Kivity wrote: > On 12/04/2011 12:33 AM, Jan Kiszka wrote: >> Do we have a convention that every include in <> is considered system >> header? Should probably be documented then (and code should be convert= ed >> gradually). >=20 > It's documented in "The C Programming Language", by K&R. It's just a convention, nothing more. If you consider certain parts of QEMU's API as system (e.g. the parts that may once make our modular API), it makes some sense to use <> for. Right now this happens for some parts of the hw API. But inconsistently. Jan --------------enig5D4AF239C4829369DB6D03DF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7bT3YACgkQitSsb3rl5xRHMgCgzU0UFxI9NzrrqKBqhXVjIzaA p6sAoOE2meZ3sgcag87vfCz1FtWitHF0 =XoF+ -----END PGP SIGNATURE----- --------------enig5D4AF239C4829369DB6D03DF--