From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC][PATCH 13/16] kvm: x86: Add user space part for in-kernel APIC Date: Sun, 04 Dec 2011 15:24:56 +0200 Message-ID: <4EDB74A8.4040604@redhat.com> References: <912e2de9716af2e4e9b6c7605b3ea08e9000fd76.1322910904.git.jan.kiszka@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl To: Jan Kiszka Return-path: In-Reply-To: <912e2de9716af2e4e9b6c7605b3ea08e9000fd76.1322910904.git.jan.kiszka@web.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 12/03/2011 01:17 PM, Jan Kiszka wrote: > From: Jan Kiszka > > This introduces the alternative APIC model 'kvm-apic' which makes use of > KVM's in-kernel device model. MSI is not yet supported, so we disable > this when the in-kernel model is in use. > > > - dev = qdev_create(NULL, "apic"); > + if (kvm_enabled() && kvm_irqchip_in_kernel()) { > + dev = qdev_create(NULL, "kvm-apic"); > + } else { > + dev = qdev_create(NULL, "apic"); > + } Is there anything that makes those two devices incompatible? -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXC3y-0002Fs-GN for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:25:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXC3x-0006M4-7A for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:25:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXC3w-0006Ll-TE for qemu-devel@nongnu.org; Sun, 04 Dec 2011 08:25:01 -0500 Message-ID: <4EDB74A8.4040604@redhat.com> Date: Sun, 04 Dec 2011 15:24:56 +0200 From: Avi Kivity MIME-Version: 1.0 References: <912e2de9716af2e4e9b6c7605b3ea08e9000fd76.1322910904.git.jan.kiszka@web.de> In-Reply-To: <912e2de9716af2e4e9b6c7605b3ea08e9000fd76.1322910904.git.jan.kiszka@web.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC][PATCH 13/16] kvm: x86: Add user space part for in-kernel APIC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl On 12/03/2011 01:17 PM, Jan Kiszka wrote: > From: Jan Kiszka > > This introduces the alternative APIC model 'kvm-apic' which makes use of > KVM's in-kernel device model. MSI is not yet supported, so we disable > this when the in-kernel model is in use. > > > - dev = qdev_create(NULL, "apic"); > + if (kvm_enabled() && kvm_irqchip_in_kernel()) { > + dev = qdev_create(NULL, "kvm-apic"); > + } else { > + dev = qdev_create(NULL, "apic"); > + } Is there anything that makes those two devices incompatible? -- error compiling committee.c: too many arguments to function