From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259 Date: Sun, 04 Dec 2011 15:06:26 +0100 Message-ID: <4EDB7E62.7090909@web.de> References: <4EDB762C.7090909@redhat.com> <4EDB78DE.6000109@web.de> <4EDB7A74.4060804@redhat.com> <4EDB7ADC.50906@web.de> <4EDB7DE2.2050301@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFE95A79358610EEDA07AABD3" Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel , Anthony Liguori , "Michael S. Tsirkin" , Blue Swirl To: Avi Kivity Return-path: Received: from fmmailgate01.web.de ([217.72.192.221]:59136 "EHLO fmmailgate01.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753735Ab1LDOG3 (ORCPT ); Sun, 4 Dec 2011 09:06:29 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate01.web.de (Postfix) with ESMTP id 05AC01A428961 for ; Sun, 4 Dec 2011 15:06:28 +0100 (CET) In-Reply-To: <4EDB7DE2.2050301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFE95A79358610EEDA07AABD3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-04 15:04, Avi Kivity wrote: > On 12/04/2011 03:51 PM, Jan Kiszka wrote: >>> >>> But the name becomes part of the save/restore ABI, so you can't. >> >> Nope, the vmstate names are identical. That would ruin migration >> otherwise. It's just the output of info qtree & co. that changes. >=20 > Oh, okay. I still think it's wrong, but now it's just a matter of > taste, and I can live with it. Wrong in what sense? I think the way of merging kvm support into the user space models in qemu-kvm is not particularly beautiful. But that's my taste, and therefore I modeled the upstream proposal differently. :) Jan --------------enigFE95A79358610EEDA07AABD3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7bfmIACgkQitSsb3rl5xQIEwCdFkR2Ais2kXOC7FcPVIZkOHQd Cw4AoM9CgDY2/2ZmPdZxcVelSLlKKZAQ =8eb1 -----END PGP SIGNATURE----- --------------enigFE95A79358610EEDA07AABD3-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXCi6-0005CD-EK for qemu-devel@nongnu.org; Sun, 04 Dec 2011 09:06:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXCi5-0005gN-GA for qemu-devel@nongnu.org; Sun, 04 Dec 2011 09:06:30 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:59128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXCi5-0005gG-1g for qemu-devel@nongnu.org; Sun, 04 Dec 2011 09:06:29 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate01.web.de (Postfix) with ESMTP id 3B5BB1A42895F for ; Sun, 4 Dec 2011 15:06:28 +0100 (CET) Message-ID: <4EDB7E62.7090909@web.de> Date: Sun, 04 Dec 2011 15:06:26 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4EDB762C.7090909@redhat.com> <4EDB78DE.6000109@web.de> <4EDB7A74.4060804@redhat.com> <4EDB7ADC.50906@web.de> <4EDB7DE2.2050301@redhat.com> In-Reply-To: <4EDB7DE2.2050301@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFE95A79358610EEDA07AABD3" Subject: Re: [Qemu-devel] [RFC][PATCH 14/16] kvm: x86: Add user space part for in-kernel i8259 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , qemu-devel , Blue Swirl This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFE95A79358610EEDA07AABD3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-12-04 15:04, Avi Kivity wrote: > On 12/04/2011 03:51 PM, Jan Kiszka wrote: >>> >>> But the name becomes part of the save/restore ABI, so you can't. >> >> Nope, the vmstate names are identical. That would ruin migration >> otherwise. It's just the output of info qtree & co. that changes. >=20 > Oh, okay. I still think it's wrong, but now it's just a matter of > taste, and I can live with it. Wrong in what sense? I think the way of merging kvm support into the user space models in qemu-kvm is not particularly beautiful. But that's my taste, and therefore I modeled the upstream proposal differently. :) Jan --------------enigFE95A79358610EEDA07AABD3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7bfmIACgkQitSsb3rl5xQIEwCdFkR2Ais2kXOC7FcPVIZkOHQd Cw4AoM9CgDY2/2ZmPdZxcVelSLlKKZAQ =8eb1 -----END PGP SIGNATURE----- --------------enigFE95A79358610EEDA07AABD3--