All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: fix endianess handling
Date: Mon, 05 Dec 2011 01:10:35 +0100	[thread overview]
Message-ID: <4EDC0BFB.4080802@googlemail.com> (raw)
In-Reply-To: <20111204150859.7F4E9824CD@gemini.denx.de>

On 12/04/2011 04:08 PM, Wolfgang Denk wrote:
> Dear Shinya Kuribayashi,
>
> In message<4EDB8475.1080305@pobox.com>  you wrote:
>>
>>>> -pb1000                       mips        mips32      pb1x00              -              au1x00      pb1x00:PB1000
>>>> +pb1000                       mips        mips32      pb1x00              -              au1x00      pb1x00:PB1000,SYS_LITTLE_ENDIAN
> ...
>> But I don't see any reason CONFIG_SYS_LITTLE_ENDIAN is specified in
>> boards.cfg.  Just putting it in configs/pb1000.h is enough, isn't it?
>
> Agreed.  In almost all cases this should be done in the board config
> file only.  Only if there are cases where a board suppors both LE and
> BE configurations (is there any such board??) then we should need a
> SYS_*_ENDIAN setting in boards.cfg (but even then, only one - not
> two).

I did this because of dbau1550 and dbau1550_el. For the pb1000 I'll
move it to the board config.

>
> Best regards,
>
> Wolfgang Denk
>


-- 
Best regards,
Daniel

  reply	other threads:[~2011-12-05  0:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 13:42 [U-Boot] [PATCH] MIPS: fix endianess handling Daniel Schwierzeck
     [not found] ` <CACUy__XYf2Zo3d0SQ7Ub-ea37C2X=gZ+bTMTX95vz+YdAeQhDw@mail.gmail.com>
2011-12-04 14:32   ` Shinya Kuribayashi
2011-12-04 15:08     ` Wolfgang Denk
2011-12-05  0:10       ` Daniel Schwierzeck [this message]
2012-03-31 20:54         ` Marek Vasut
     [not found] ` <4EDB5F86.40605@googlemail.com>
2011-12-04 15:06   ` Wolfgang Denk
2011-12-05  0:04     ` Daniel Schwierzeck
2011-12-05 10:05       ` Wolfgang Denk
2011-12-07 12:59 ` [U-Boot] [PATCH v2] " Daniel Schwierzeck
2011-12-11 16:53   ` [U-Boot] [PATCH v3] " Daniel Schwierzeck
2011-12-16 18:12     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDC0BFB.4080802@googlemail.com \
    --to=daniel.schwierzeck@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.