From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXVPd-0000Ho-RD
	for qemu-devel@nongnu.org; Mon, 05 Dec 2011 05:04:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXVPa-0005kK-0B
	for qemu-devel@nongnu.org; Mon, 05 Dec 2011 05:04:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45454)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RXVPZ-0005kG-O9
	for qemu-devel@nongnu.org; Mon, 05 Dec 2011 05:04:37 -0500
Message-ID: <4EDC9732.1070102@redhat.com>
Date: Mon, 05 Dec 2011 12:04:34 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1323022181-28110-1-git-send-email-avi@redhat.com>
	<1323022181-28110-4-git-send-email-avi@redhat.com>
	<CAAu8pHs+E9F1-sTfaMSwGsUN=rCDMHZc_xt9ZJndiKe0sts2Zg@mail.gmail.com>
In-Reply-To: <CAAu8pHs+E9F1-sTfaMSwGsUN=rCDMHZc_xt9ZJndiKe0sts2Zg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/6] memory: introduce
	memory_region_set_alias_offset()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 12/04/2011 11:34 PM, Blue Swirl wrote:
> On Sun, Dec 4, 2011 at 18:09, Avi Kivity <avi@redhat.com> wrote:
> > Add an API to update an alias offset of an active alias.  This can be
> > used to simplify implementation of dynamic memory banks.
> >
> >  */
> > -void memory_region_set_address(MemoryRegion *mr, target_phys_addr_t addr);
> > +void memory_region_set_address(MemoryRegion *mr, target_phys_addr_t offset);
>
> This isn't the function you are looking for, but still 'addr' is
> changed to 'offset'.
>
> > +
> > +/*
> > + * memory_region_set_alias_offset: dynamically update a memory alias's offset
> > + *
> > + * Dynamically updates the offset into the target region that an alias points
> > + * to, as if the fourth argument to memory_region_init_alias() has changed.
> > + *
> > + * @mr: the #MemoryRegion to be updated; should be an alias.
> > + * @offset: the new offset into the target memory region
> > + */
> > +void memory_region_set_alias_offset(MemoryRegion *mr, target_phys_addr_t addr);
>
> Here 'addr' doesn't match the description above.

Thanks, fixed.

-- 
error compiling committee.c: too many arguments to function