All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] block: fix and detect qemu_aio_wait() issues
Date: Mon, 05 Dec 2011 14:57:01 +0100	[thread overview]
Message-ID: <4EDCCDAD.8090108@redhat.com> (raw)
In-Reply-To: <1322655824-31778-1-git-send-email-stefanha@linux.vnet.ibm.com>

Am 30.11.2011 13:23, schrieb Stefan Hajnoczi:
> This series fixes an issue where qemu_aio_flush() would return to IDE hardware
> emulation with requests still pending.  Kevin Wolf <kwolf@redhat.com> found it
> in the block tree before qemu.git/master merge, so qemu.git/master is not
> affected and these patches are against his tree.
> 
> A recent interaction between copy-on-read and "qcow2: Unlock during COW"
> emphasized the need for strong assertion checking.  Patch 1 fixes an assertion
> failure with qcow2 images in hw/ide/pci.c:bmdma_cmd_writeb().
> 
> Patches 2 and 3 then introduce assertions that detect
> wait_for_overlapping_requests() deadlock and broken qemu_aio_wait().  In the
> future we will have better information if issues related to qemu_aio_wait()
> come up.
> 
> I have run qemu-iotests for qcow2 and qed.  I have also performed a RHEL6 guest
> install to qed and tested booting the guest with IDE and qcow2.
> 
> Stefan Hajnoczi (3):
>   qcow2: avoid reentrant bdrv_read() in copy_sectors()
>   block: wait_for_overlapping_requests() deadlock detection
>   block: convert qemu_aio_flush() calls to bdrv_drain_all()

Thanks, applied all to the block branch.

Kevin

      parent reply	other threads:[~2011-12-05 13:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 12:23 [Qemu-devel] [PATCH 0/3] block: fix and detect qemu_aio_wait() issues Stefan Hajnoczi
2011-11-30 12:23 ` [Qemu-devel] [PATCH 1/3] qcow2: avoid reentrant bdrv_read() in copy_sectors() Stefan Hajnoczi
2011-11-30 12:23 ` [Qemu-devel] [PATCH 2/3] block: wait_for_overlapping_requests() deadlock detection Stefan Hajnoczi
2011-11-30 12:23 ` [Qemu-devel] [PATCH 3/3] block: convert qemu_aio_flush() calls to bdrv_drain_all() Stefan Hajnoczi
2011-11-30 12:28   ` Christoph Hellwig
2011-11-30 12:54     ` Stefan Hajnoczi
2011-12-05 13:57 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDCCDAD.8090108@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.