From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 12/17] usb: Add support for txfifo threshold
Date: Mon, 05 Dec 2011 16:32:00 -0700 [thread overview]
Message-ID: <4EDD5470.9080405@nvidia.com> (raw)
In-Reply-To: <1322878300-5551-13-git-send-email-sjg@chromium.org>
On 12/02/2011 07:11 PM, Simon Glass wrote:
> CONFIG_USB_EHCI_TXFIFO_THRESH enables setting of the txfilltuning
> field in the EHCI controller on reset.
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 3d0ad0c..cc00ce4 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -80,7 +80,11 @@ struct ehci_hcor {
> uint32_t or_ctrldssegment;
> uint32_t or_periodiclistbase;
> uint32_t or_asynclistaddr;
> - uint32_t _reserved_[9];
> + uint32_t _reserved_0_;
Why not remove _reserved_0_ ...
> + uint32_t or_burstsize;
> + uint32_t or_txfilltuning;
> +#define TXFIFO_THRESH(p) ((p & 0x3f) << 16)
> + uint32_t _reserved_1_[6];
... and make _reserved_1_ 1 element bigger and keep it named _reserved_?
The result would be a little simpler.
> uint32_t or_configflag;
> #define FLAG_CF (1 << 0) /* true: we'll support "high speed" */
> uint32_t or_portsc[CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS];
--
nvpublic
next prev parent reply other threads:[~2011-12-05 23:32 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 2:11 [U-Boot] [PATCH v2 0/17] tegra: Add fdt definitions and USB driver Simon Glass
2011-12-03 2:11 ` [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
2011-12-05 21:27 ` Stephen Warren
2011-12-05 21:27 ` [U-Boot] " Stephen Warren
2011-12-05 21:40 ` Simon Glass
2011-12-05 21:40 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ0h39vB2H4MuCwVqb2Tgcr4==yN8Pj6a3s9dciyXPBu1A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 22:07 ` Stephen Warren
2011-12-05 22:07 ` [U-Boot] " Stephen Warren
[not found] ` <4EDD4091.1030708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-12-05 22:11 ` Simon Glass
2011-12-05 22:11 ` [U-Boot] " Simon Glass
2011-12-05 22:18 ` Scott Wood
2011-12-05 22:18 ` [U-Boot] " Scott Wood
2011-12-05 22:25 ` Stephen Warren
2011-12-05 22:25 ` [U-Boot] " Stephen Warren
2011-12-05 22:53 ` Simon Glass
2011-12-05 22:53 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [U-Boot] [PATCH v2 03/17] Add gpio_request() to asm-generic header Simon Glass
[not found] ` <1322878300-5551-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-03 2:11 ` [PATCH v2 02/17] fdt: Add functions to access phandles, arrays and bools Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
[not found] ` <1322878300-5551-3-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-05 21:59 ` Stephen Warren
2011-12-05 21:59 ` [U-Boot] " Stephen Warren
[not found] ` <4EDD3EDE.4000609-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-12-05 22:07 ` Simon Glass
2011-12-05 22:07 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ30Bmxp4eGCgYss9GHt=SN5X5-sSHrPJpZFjVjprpa_Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 22:36 ` Stephen Warren
2011-12-05 22:36 ` [U-Boot] " Stephen Warren
2011-12-05 23:56 ` Simon Glass
2011-12-05 23:56 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [PATCH v2 04/17] fdt: Add basic support for decoding GPIO definitions Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
[not found] ` <1322878300-5551-5-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-05 21:46 ` Stephen Warren
2011-12-05 21:46 ` [U-Boot] " Stephen Warren
2011-12-05 21:56 ` Simon Glass
2011-12-05 21:56 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ3ARCTXVN2MKhfrdCCmmb21zbYdSq8AuQFPdoA=xFr7Mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 22:22 ` Stephen Warren
2011-12-05 22:22 ` [U-Boot] " Stephen Warren
[not found] ` <4EDD440C.80002-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-12-05 22:52 ` Simon Glass
2011-12-05 22:52 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ03+tfMhkqo4=uarcAf1E8hTfvSF_Y0=V70tuqP866QQQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-05 23:03 ` Stephen Warren
2011-12-05 23:03 ` [U-Boot] " Stephen Warren
[not found] ` <4EDD4DA7.6070902-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-12-05 23:29 ` Simon Glass
2011-12-05 23:29 ` [U-Boot] " Simon Glass
2011-12-06 3:55 ` Mike Frysinger
2011-12-06 3:55 ` [U-Boot] " Mike Frysinger
2011-12-07 1:21 ` Simon Glass
2011-12-07 1:21 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [PATCH v2 05/17] arm: fdt: Ensure that an embedded fdt is word-aligned Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [PATCH v2 07/17] tegra: fdt: Add Tegra2x device tree file from kernel Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [PATCH v2 08/17] tegra: fdt: Add device tree file for Tegra2 Seaboard " Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [PATCH v2 09/17] tegra: usb: fdt: Add additional device tree definitions for USB ports Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
[not found] ` <1322878300-5551-10-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-05 23:25 ` Stephen Warren
2011-12-05 23:25 ` [U-Boot] " Stephen Warren
2011-12-06 0:55 ` Simon Glass
2011-12-06 0:55 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ1J_cOS_E+ZiDoZUh79V7LUFzVkx-0nhbPTDwuGCGvDnQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-06 20:28 ` Stephen Warren
2011-12-06 20:28 ` [U-Boot] " Stephen Warren
2011-12-06 21:09 ` Simon Glass
2011-12-06 21:09 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ035Cen11ObFXjKUCqypvVKzkewhfY2F=yGH8=RWxVuSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-07 23:36 ` Stephen Warren
2011-12-07 23:36 ` [U-Boot] " Stephen Warren
[not found] ` <4EDFF898.1070708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-12-08 21:10 ` Simon Glass
2011-12-08 21:10 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ1adfU652Z2ob30GTWZiCnah4WsJNfVrroWvtM5LXW93Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-12 18:13 ` Stephen Warren
2011-12-12 18:13 ` [U-Boot] " Stephen Warren
2011-12-12 18:53 ` Simon Glass
2011-12-12 18:53 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [PATCH v2 10/17] tegra: usb: fdt: Add USB definitions for Tegra2 Seaboard Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
[not found] ` <1322878300-5551-11-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-05 23:26 ` Stephen Warren
2011-12-05 23:26 ` [U-Boot] " Stephen Warren
2011-12-03 2:11 ` [PATCH v2 17/17] tegra: fdt: Enable FDT support for Seaboard Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [PATCH v2 06/17] arm: fdt: Add skeleton device tree file from kernel Simon Glass
2011-12-03 2:11 ` [U-Boot] " Simon Glass
2011-12-03 2:11 ` [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment Simon Glass
2011-12-04 11:13 ` Remy Bohmer
2011-12-06 2:38 ` Simon Glass
2011-12-10 16:04 ` Remy Bohmer
2011-12-10 18:58 ` Simon Glass
2011-12-03 2:11 ` [U-Boot] [PATCH v2 12/17] usb: Add support for txfifo threshold Simon Glass
2011-12-05 23:32 ` Stephen Warren [this message]
2011-12-06 2:03 ` Simon Glass
2011-12-06 18:58 ` Stephen Warren
2011-12-06 19:24 ` Simon Glass
2011-12-03 2:11 ` [U-Boot] [PATCH v2 13/17] tegra: usb: Add support for Tegra USB peripheral Simon Glass
2011-12-04 11:12 ` Remy Bohmer
2011-12-03 2:11 ` [U-Boot] [PATCH v2 14/17] tegra: usb: Add USB support to nvidia boards Simon Glass
2011-12-03 2:11 ` [U-Boot] [PATCH v2 15/17] tegra: usb: Add common USB defines for tegra2 boards Simon Glass
2011-12-03 2:11 ` [U-Boot] [PATCH v2 16/17] tegra: usb: Enable USB on Seaboard Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDD5470.9080405@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.