From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ma Date: Tue, 06 Dec 2011 13:18:16 +0800 Subject: [Ocfs2-devel] [PATCH] ocfs2: submit disk heartbeat bio using WRITE_SYNC In-Reply-To: <1323147430-16691-1-git-send-email-n_iwamatsu@jp.fujitsu.com> References: <1323147430-16691-1-git-send-email-n_iwamatsu@jp.fujitsu.com> Message-ID: <4EDDA598.50708@tao.ma> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On 12/06/2011 12:57 PM, Noboru Iwamatsu wrote: > Under heavy I/O load, writing the disk heartbeat can be forced > to wait for minutes, and this causes the node to be fenced. > > This patch tries to use WRITE_SYNC in submitting the heartbeat > bio, so that writing the heartbeat will have a priority over > other requests. > > Signed-off-by: Noboru Iwamatsu looks good to me. Acked-by: Tao Ma > --- > fs/ocfs2/cluster/heartbeat.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c > index 9a3e6bb..6b0c1e4 100644 > --- a/fs/ocfs2/cluster/heartbeat.c > +++ b/fs/ocfs2/cluster/heartbeat.c > @@ -491,7 +491,7 @@ static int o2hb_issue_node_write(struct o2hb_region *reg, > } > > atomic_inc(&write_wc->wc_num_reqs); > - submit_bio(WRITE, bio); > + submit_bio(WRITE_SYNC, bio); > > status = 0; > bail: