From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Michael Hennerich <michael.hennerich@analog.com>,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] staging:iio:dac: Add AD5380 driver
Date: Tue, 06 Dec 2011 09:59:02 +0100 [thread overview]
Message-ID: <4EDDD956.4080908@metafoo.de> (raw)
In-Reply-To: <4EDD3F14.804@kernel.org>
On 12/05/2011 11:00 PM, Jonathan Cameron wrote:
> On 12/05/2011 04:08 PM, Lars-Peter Clausen wrote:
>> This patch adds support for the Analog Devices D5380, AD5381,
>> AD5382, AD5383, AD5384, AD5390, AD5391, AD5392 multi-channel
>> Digital to Analog Converters.
>>
> Lars-Peter
>
> Just got a build warning on this you probably want to check out...
>
> drivers/staging/iio/dac/ad5380.c:150:10: warning: Initializer entry
> defined twice
> drivers/staging/iio/dac/ad5380.c:160:10: also defined here
>
> Trivial, but good to fix!
> Jonathan
Yes, especially since this breaks support for the AD5391-5.
(I always wonder why my compiler doesn't give me these warnings)
Thanks,
- Lars
next prev parent reply other threads:[~2011-12-06 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 16:08 [PATCH] staging:iio:dac: Add AD5380 driver Lars-Peter Clausen
2011-12-05 22:00 ` Jonathan Cameron
2011-12-06 8:59 ` Lars-Peter Clausen [this message]
2011-12-06 10:25 ` Jonathan Cameron
2011-12-06 9:07 ` [PATCH v2] " Lars-Peter Clausen
-- strict thread matches above, loose matches on Subject: below --
2011-11-18 10:54 [PATCH] " Lars-Peter Clausen
2011-11-18 13:10 ` J.I. Cameron
2011-11-18 13:15 ` J.I. Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDDD956.4080908@metafoo.de \
--to=lars@metafoo.de \
--cc=devel@driverdev.osuosl.org \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=gregkh@suse.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.