From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 16/19] Rename get_tls to tls_var
Date: Tue, 06 Dec 2011 13:04:43 +0100 [thread overview]
Message-ID: <4EDE04DB.6070107@redhat.com> (raw)
In-Reply-To: <4EDDFFE3.0@suse.de>
On 12/06/2011 12:43 PM, Andreas Färber wrote:
> Am 06.12.2011 12:01, schrieb Stefan Hajnoczi:
>> From: Jan Kiszka<jan.kiszka@siemens.com>
>>
>> get_tls() can serve as a lvalue as well, so 'get' might be confusing.
>
> Note that this does not work for POSIX pthread_getspecific(), which
> we'll need to support at some point in time, so I don't think this is a
> terribly good idea.
I already posted the code for pthread_getspecific(), but it didn't work
on OpenBSD.
The idea was to reserve a single pthread key and allocate a whole block
of memory. Then get_tls can use pthread_getspecific() and add an offset
within the block of memory. The reason is that with many allocated keys
pthread_getspecific() becomes slower.
Paolo
next prev parent reply other threads:[~2011-12-06 12:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 11:00 [Qemu-devel] [PULL 00/19] Trivial patches for 3 to 6 December 2011 Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 01/19] console: Clean up confusing indentation in console_putchar() Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 02/19] console: Fix console_putchar() for CSI J Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 03/19] console: Fix qemu_default_pixelformat() for 24 bpp Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 04/19] configure: Include #define name in check_define compiler error Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 05/19] configure: Print a banner comment at the top of config.log Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 06/19] net/socket.c : fix memory leak Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 07/19] win32: " Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 08/19] fix typo: delete redundant semicolon Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 09/19] fix spelling in hw sub directory Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 10/19] pcie_aer: adjust do_pcie_aer_inejct_error -> do_pcie_aer_inject_error Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 11/19] configure: Pull linux-headers/asm symlink creation out of loop Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 12/19] Convert source files to UTF-8 encoding Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 13/19] Convert keymap file " Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 14/19] linux-user/cpu-uname.c: Convert to UTF-8 Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 15/19] linux-user/arm/nwfpe/fpopcode.h: Fix non-UTF-8 characters Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 16/19] Rename get_tls to tls_var Stefan Hajnoczi
2011-12-06 11:43 ` Andreas Färber
2011-12-06 11:47 ` Jan Kiszka
2011-12-06 12:04 ` Paolo Bonzini [this message]
2011-12-06 11:01 ` [Qemu-devel] [PATCH 17/19] linux-user/syscall.c: Don't skip stracing for fcntl64 failure case Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 18/19] memory: minor documentation fixes/enhancements Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 19/19] mips_malta: resolve endless loop when loading bios Stefan Hajnoczi
2011-12-14 10:38 ` [Qemu-devel] [PULL 00/19] Trivial patches for 3 to 6 December 2011 Stefan Hajnoczi
2011-12-14 14:53 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDE04DB.6070107@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.