From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RXyxa-0005Fi-SC
	for qemu-devel@nongnu.org; Tue, 06 Dec 2011 12:37:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RXyxR-0004Sx-6X
	for qemu-devel@nongnu.org; Tue, 06 Dec 2011 12:37:42 -0500
Received: from thoth.sbs.de ([192.35.17.2]:21375)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RXyxQ-0004Sq-U6
	for qemu-devel@nongnu.org; Tue, 06 Dec 2011 12:37:33 -0500
Message-ID: <4EDE52DB.9060506@siemens.com>
Date: Tue, 06 Dec 2011 18:37:31 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1323191155-22549-1-git-send-email-pbonzini@redhat.com>
	<1323191155-22549-3-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1323191155-22549-3-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] qemu-thread: implement joinable
	threads for POSIX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "alevy@redhat.com" <alevy@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2011-12-06 18:05, Paolo Bonzini wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Allow to control if a QEMU thread is created joinable or not. Make it
> not joinable by default to avoid that we keep the associated resources
> around when terminating a thread without joining it (what we couldn't do
> so far for obvious reasons).
> 
> The audio subsystem will need the join feature when converting it to
> QEMU threading/locking abstractions, so provide that service.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu-thread-posix.c |   28 ++++++++++++++++++++++++++++--
>  1 files changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
> index 49d3388..603ff3d 100644
> --- a/qemu-thread-posix.c
> +++ b/qemu-thread-posix.c
> @@ -122,16 +122,28 @@ void qemu_thread_create(QemuThread *thread,
>      sigset_t set, oldset;
>      int err;
>  
> -    assert(mode == QEMU_THREAD_DETACHED);
> +    pthread_attr_t attr;

Minor nit: blank line here instead. Fine otherwise.

Jan

> +    err = pthread_attr_init(&attr);
> +    if (err) {
> +        error_exit(err, __func__);
> +    }
> +    if (mode == QEMU_THREAD_DETACHED) {
> +        err = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
> +        if (err) {
> +            error_exit(err, __func__);
> +        }
> +    }
>  
>      /* Leave signal handling to the iothread.  */
>      sigfillset(&set);
>      pthread_sigmask(SIG_SETMASK, &set, &oldset);
> -    err = pthread_create(&thread->thread, NULL, start_routine, arg);
> +    err = pthread_create(&thread->thread, &attr, start_routine, arg);
>      if (err)
>          error_exit(err, __func__);
>  
>      pthread_sigmask(SIG_SETMASK, &oldset, NULL);
> +
> +    pthread_attr_destroy(&attr);
>  }
>  
>  void qemu_thread_get_self(QemuThread *thread)
> @@ -148,3 +162,15 @@ void qemu_thread_exit(void *retval)
>  {
>      pthread_exit(retval);
>  }
> +
> +void *qemu_thread_join(QemuThread *thread)
> +{
> +    int err;
> +    void *ret;
> +
> +    err = pthread_join(thread->thread, &ret);
> +    if (err) {
> +        error_exit(err, __func__);
> +    }
> +    return ret;
> +}

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux