From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Schwarz <simonschwarzcor@googlemail.com>
Date: Tue, 06 Dec 2011 19:06:23 +0100
Subject: [U-Boot] [PATCH V7 5/5] omap-common: fixes BSS overwriting
	problem
In-Reply-To: <4EDE4E54.7060602@denx.de>
References: <1317284033-16188-1-git-send-email-simonschwarzcor@gmail.com>
	<1320078187-28423-1-git-send-email-simonschwarzcor@gmail.com>
	<1320078187-28423-6-git-send-email-simonschwarzcor@gmail.com>
	<4EDE4E54.7060602@denx.de>
Message-ID: <4EDE599F.2040902@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/06/2011 06:18 PM, Stefano Babic wrote:
> On 31/10/2011 17:23, Simon Schwarz wrote:
>> From: Simon Schwarz<simonschwarzcor@googlemail.com>
>>
>> spl_nand overwrote BSS section because it reads a whole block everytime. Now
>> loads the block to spare area and just copy the needed junk to destination.
>> Whole block read is necessary for ecc check!
>>
>> Signed-off-by: Simon Schwarz<simonschwarzcor@gmail.com>
>> ---
>
>> @@ -71,7 +71,8 @@ void spl_nand_load_image(void)
>>   			CONFIG_SYS_NAND_PAGE_SIZE, (void *)header);
>>   		spl_parse_image_header(header);
>>   		nand_spl_load_image(CONFIG_SYS_NAND_SPL_KERNEL_OFFS,
>> -			spl_image.size, (void *)spl_image.load_addr);
>> +			spl_image.size,
>> +			(void *)spl_image.load_addr - sizeof(header));
>                                                               ^---
>
>
> Do you mean maybe sizeof(*header) ?
>
> However, spl_image.load_addr was already decremented in
> spl_parse_image_header() and correctly set to 64 byte before the load
> address. Do we really need it ?
>
[SNIP]
> Best regards,
> Stefano Babic
>

You are right -> V9. Lets see if we get it to two digits ;)

Regards
Simon