All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 1/5] ASoC: Hold runtime PM references to components of active DAIs
Date: Wed, 07 Dec 2011 09:47:29 +0200	[thread overview]
Message-ID: <4EDF1A11.6080108@ti.com> (raw)
In-Reply-To: <20111205150747.GS11150@opensource.wolfsonmicro.com>

On 12/05/2011 05:07 PM, Mark Brown wrote:
>> The ordering of the pm_runtime_get/put will be different.
>> We will have the pm_runtime_put after all other parts of the audio
>> system has been closed, turned off.
> 
> Hrm, yes.  But that's much wider than just the issue with moving inside
> the pcm_lock - for example, the shutdown calls already come before the
> DAPM teardowns.

Sure, ideally I would pair the pm_runtime calls with the corresponding
startup/shutdown callback.

> So it sounds like things are OK with the proposed patch then, though
> there's still some larger issues to work through?

Yes, correct. I need to have pm_runtime support for the external
functional clock for the McPDM (coming as bit clock from twl6040 codec).

-- 
Péter

  reply	other threads:[~2011-12-07  7:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05  0:01 [PATCH 1/5] ASoC: Hold runtime PM references to components of active DAIs Mark Brown
2011-12-05  0:01 ` [PATCH 2/5] ASoC: Use core pm_runtime callbacks for omap-dmic Mark Brown
2011-12-05  8:02   ` Peter Ujfalusi
2011-12-05  0:01 ` [PATCH 3/5] ASoC: Use core pm_runtime callbacks for omap-mcpdm Mark Brown
2011-12-05  8:32   ` Peter Ujfalusi
2011-12-05  0:01 ` [PATCH 4/5] ASoC: Use core pm_runtime callbacks for siu_dai Mark Brown
2011-12-05  0:01 ` [PATCH 5/5] ASoC: Use core pm_runtime callbacks for fsi Mark Brown
2011-12-05  8:01 ` [PATCH 1/5] ASoC: Hold runtime PM references to components of active DAIs Peter Ujfalusi
2011-12-05 11:39   ` Mark Brown
2011-12-05 13:32     ` Peter Ujfalusi
2011-12-05 13:46       ` Mark Brown
2011-12-05 14:53         ` Peter Ujfalusi
2011-12-05 15:07           ` Mark Brown
2011-12-07  7:47             ` Peter Ujfalusi [this message]
2011-12-07  7:48 ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDF1A11.6080108@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.