Re: [PATCH] xfstests/071 FAIL with pwrite64: Invalid argument

[Peng Haitao <penght@cn.fujitsu.com>]

Hi, 

Dave Chinner said the following on 2011-12-6 19:05:
>> When offset + length is overflow of xfs_io builtin pread and pwrite in linux,
>> the error message should be "Invalid argument".
> 
> Fixing this just requires an additional filter. The write outpu is
> already passed through 2 filters to remove ariable numbers from the
> output, so one more to standardise the error isn't a problem.
> 
> Further, filtering of the error stream on the reads to only appear
> in $seq.full solves the extra error output on reads as well.
> 

Thanks for your comments.

When offset + length is overflow, the case expect:
  - pwrite output error messages: pwrite64: File too large
  - pread output right message:   read 0/512 bytes at offset <OFFSET>

but in linux, the actual results:
  - pwrite output error messages: pwrite64: Invalid argument
  - pread output right message:   pread64: Invalid argument

I can add an additional filter to remove variable messages, 
but if I remove variable messages, the 071.out will remain echo content:
Writing 512 bytes, offset is +0 (direct=false)
Reading 512 bytes (direct=false)
...

This will make the case meaningless.

-- 
Best Regards,
Peng Haitao

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs