From: Tao Ma <tm@tao.ma>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: djwong@us.ibm.com, Theodore Ts'o <tytso@mit.edu>,
ext4 development <linux-ext4@vger.kernel.org>,
Liang Zhen <liang@whamcloud.com>
Subject: Re: [PATCH 01/02] ext2: reserve INCOMPAT_INLINEDATA feature flag
Date: Wed, 07 Dec 2011 18:14:23 +0800 [thread overview]
Message-ID: <4EDF3C7F.4090801@tao.ma> (raw)
In-Reply-To: <D24AD8E4-9B72-4518-9CC9-99FBB143BB62@whamcloud.com>
On 12/07/2011 05:45 PM, Andreas Dilger wrote:
> On 2011-12-06, at 5:39 PM, Darrick J. Wong wrote:
>> On Tue, Dec 06, 2011 at 05:13:51PM -0700, Andreas Dilger wrote:
>>> +#define EXT4_FEATURE_INCOMPAT_INLINEDATA 0x2000 /* data in inode */
>>
>> I was using 0x2000 for EXT4_FEATURE_INCOMPAT_BG_USE_META_CSUM, to change
>> the block group checksum to use crc32c.
>
> I didn't see that... I was looking at your patch and only noticed
> EXT4_FEATURE_RO_COMPAT_METADATA_CSUM. I suspect your patch is closer
> to landing it is better to use the 0x2000 value for BG_USE_META_CSUM,
> and change the value for INLINEDATA to 0x8000 instead.
OK, I will use this number for inline data for the new version if there
is no objection.
Thanks
Tao
next prev parent reply other threads:[~2011-12-07 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 0:05 [PATCH 00/02] ext2: Reserve feature flags Andreas Dilger
2011-12-07 0:13 ` [PATCH 01/02] ext2: reserve INCOMPAT_INLINEDATA feature flag Andreas Dilger
2011-12-07 0:39 ` Darrick J. Wong
2011-12-07 9:45 ` Andreas Dilger
2011-12-07 10:14 ` Tao Ma [this message]
2011-12-07 1:43 ` Tao Ma
2011-12-07 0:16 ` [PATCH 02/02] ext2: reserve INCOMPAT_LARGEDIR " Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF3C7F.4090801@tao.ma \
--to=tm@tao.ma \
--cc=adilger@whamcloud.com \
--cc=djwong@us.ibm.com \
--cc=liang@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.