From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH/RFC] gen_atmel_mci: add mci_set_data_timeout()
Date: Wed, 07 Dec 2011 14:44:08 +0100 [thread overview]
Message-ID: <4EDF6DA8.80407@gmail.com> (raw)
In-Reply-To: <1318595788-21184-1-git-send-email-biessmann@corscience.de>
Dear Andy Fleming,
Am 14.10.2011 14:36, schrieb Andreas Bie?mann:
> Before the DTOR register is set to a fixed value and resulted in some cards
> not working. Setting the fixed value to a hihger value is not appropriate
> cause we could wait way to long for slow clock rates.
>
> This patch moves the mci_set_data_timeout() from old atmel_mci driver to
> gen_atmel_mci driver and adopts to the parameters. In contrast to the origin
> this version of mci_set_data_timeout() relies on some fixed input values for
> timeout_ns and timeout_clks. Before these values where taken from the card's
> CSD.
>
> Signed-off-by: Andreas Bie?mann <biessmann@corscience.de>
> CC: Sven Schnelle <svens@stackframe.org>
> CC: Reinhard Meyer <u-boot@emk-elektronik.de>
> CC: Andy Fleming <afleming@gmail.com>
> ---
> RESENT TO LIST ...
>
> This is an RFC. The most questionary thing is whether we use fixed values for
> timeout_ns/timeout_clks or take the values from CSD as before.
>
> I wonder if we should add the taac and nsac values to the mmc struct or if we
> should handle the mmc->csd[] inside the driver if we requiore the card data as
> input for the timeout equtation.
>
> Please read also http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/112056/focus=112057
This is the patch in question (see discussion @
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/119611/focus=119626)
Is it OK for you to use the fixed values for timeout_ns/timeout_clks
here or should we
a) use the mmc->csd[] values in the respective driver?
or
b) introduce some generic handling for mmc->csd[]?
best regards
Andreas Bie?mann
prev parent reply other threads:[~2011-12-07 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 12:36 [U-Boot] [PATCH/RFC] gen_atmel_mci: add mci_set_data_timeout() Andreas Bießmann
2011-12-07 13:44 ` Andreas Bießmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF6DA8.80407@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.