From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] KVM: x86 emulator: Use opcode::execute for Group 2 instructions Date: Wed, 07 Dec 2011 18:38:42 +0200 Message-ID: <4EDF9692.8020400@redhat.com> References: <20111206180418.b4b40396.yoshikawa.takuya@oss.ntt.co.jp> <20111206180520.af9df45d.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:3158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758010Ab1LGQis (ORCPT ); Wed, 7 Dec 2011 11:38:48 -0500 In-Reply-To: <20111206180520.af9df45d.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 12/06/2011 11:05 AM, Takuya Yoshikawa wrote: > Group 2: C0, C1, D0, D1, D2, D3 > > According to the SDM, the case 6 of em_grp2() should be treated as > undefined and the opcode D2/D3 should be decoded using the SrcCL. > > > emulate_2op_SrcB(ctxt, "rcr"); > break; > case 4: /* sal/shl */ > - case 6: /* sal/shl */ > emulate_2op_SrcB(ctxt, "sal"); > break; > case 5: /* shr */ AMD processors decode grp2 /6 as sal/shl. In any case, please don't mix functional changes with refactoring. -- error compiling committee.c: too many arguments to function