From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 07 Dec 2011 19:10:32 +0100 Subject: [U-Boot] [PATCH V9 2/4] omap-common: Add NAND SPL linux booting In-Reply-To: <4EDFA8FD.9000405@gmail.com> References: <1323193179-9551-1-git-send-email-simonschwarzcor@gmail.com> <1323196478-14254-1-git-send-email-simonschwarzcor@gmail.com> <1323196478-14254-3-git-send-email-simonschwarzcor@gmail.com> <4EDF88C7.5070309@denx.de> <4EDFA8FD.9000405@gmail.com> Message-ID: <4EDFAC18.3060900@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/12/2011 18:57, Simon Schwarz wrote: >> >> So if the parse function fails, we should have the fallback to u-boot, >> exactly as we have now the fallback from u-boot.img to u-boot.bin. >> > Hm, I don't think that we want any fallback here. I would prefere an > error message and hang. The direct boot is designed to be used in the > field - so IMHO we don't want to start the bootloader automatically if a > normal startup fails. this is also reasonable - we should drop the current behavior: if Linux is not found, SPL tries to start the loaded code as u-boot.bin. Better to hang with a message. >> The function you write are in omap-common/spl_nand.c, but they are not >> specific for OMAP, and any architecture can profit from your work. What >> about to move common functions away from TI related directory ? I do not >> know which is the best place, maybe a new directory under the root as >> spllib ? > Hm thats generally right. I would prefer lib_spl. Somehow it feels like > going back to nand_spl times. Duno if there are better places? Tom probably can suggest us something.. BR, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================