From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RYMhM-00077l-67
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 13:58:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RYMhK-0005ES-J5
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 13:58:32 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1RYMhK-0004zZ-EE
	for qemu-devel@nongnu.org; Wed, 07 Dec 2011 13:58:30 -0500
Message-ID: <4EDFB719.7060904@weilnetz.de>
Date: Wed, 07 Dec 2011 19:57:29 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1323244048-6021-1-git-send-email-balrogg@gmail.com>
In-Reply-To: <1323244048-6021-1-git-send-email-balrogg@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: don't try to compile against
 known	broken curses.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrzej Zaborowski <balrogg@gmail.com>
Cc: qemu-devel@nongnu.org

Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
> This should resolve a problem noted by Caraman Mihai Claudiu.
>
> Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
> ---
> configure | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/configure b/configure
> index 61c43b9..678b982 100755
> --- a/configure
> +++ b/configure
> @@ -1846,6 +1846,11 @@ if test "$curses" != "no" ; then
> #ifdef __OpenBSD__
> #define resize_term resizeterm
> #endif
> +#ifdef NCURSES_VERSION
> +# if NCURSES_VERSION_PATCH < 20040117
> +# error Old ncurses contain dangerous typedefs, break qemu build (and 
> are old)
> +# endif
> +#endif
> int main(void) { resize_term(0, 0); return curses_version(); }
> EOF
> for curses_lib in $curses_list; do

Is NCURSES_VERSION_PATCH always defined when NCURSES_VERSION is?
If not, code like the following is more robust:

#if !defined(NCURSES_VERSION_PATCH) || NCURSES_VERSION_PATCH < 20040117
# error Old ncurses contain dangerous typedefs, break qemu build (and 
are old)
#endif

Otherwise the patch is good.

Reviewed-by: Stefan Weil <sw@weilnetz.de>