From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/13] davinci_emac: move arch-independent defines to separate header
Date: Thu, 08 Dec 2011 03:48:49 +0400 [thread overview]
Message-ID: <4EDFFB61.6020006@emcraft.com> (raw)
In-Reply-To: <4ED5DE81.2040106@compulab.co.il>
Hi Igor,
sorry for the late answer.
On 30.11.2011 11:42, Igor Grinberg wrote:
>> diff --git a/arch/arm/cpu/arm926ejs/davinci/dp83848.c b/arch/arm/cpu/arm926ejs/davinci/dp83848.c
>> index c71c685..d435e4b 100644
>> --- a/arch/arm/cpu/arm926ejs/davinci/dp83848.c
>> +++ b/arch/arm/cpu/arm926ejs/davinci/dp83848.c
>> @@ -29,6 +29,7 @@
>> #include <net.h>
>> #include <dp83848.h>
>> #include <asm/arch/emac_defs.h>
>> +#include "../../../../../drivers/net/davinci_emac.h"
>
> Doesn't this look terrible?
Yes, it does. But this will be removed once someone will switch the
driver to phylib.
> I'd suggest, to split the davinci_emac.h to driver private part
> (if there is) and to public part.
> Then put the public part into the include/ directory - just as,
> for example, dm9000 does.
Uh.. As for me, polluting the public includes is not very good idea as
well. And again I think switching to phylib use is the right solution.
This should be rather simple.
Regards, Ilya.
next prev parent reply other threads:[~2011-12-07 23:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:37 [U-Boot] [PATCH V3 00/13] Support for HTKW mcx board Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 01/13] davinci_emac: move arch-independent defines to separate header Ilya Yanok
2011-11-29 18:57 ` Tom Rini
2011-11-30 7:35 ` Igor Grinberg
2011-11-30 14:21 ` Tom Rini
2011-11-30 15:16 ` Igor Grinberg
2011-11-30 15:27 ` Tom Rini
2011-11-30 7:42 ` Igor Grinberg
2011-12-07 23:48 ` Ilya Yanok [this message]
2011-12-08 14:33 ` Igor Grinberg
2011-12-08 14:42 ` Tom Rini
2011-12-08 15:13 ` Igor Grinberg
2011-11-28 16:37 ` [U-Boot] [PATCH 02/13] davinci_emac: use internal addresses in buffer descriptors Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 03/13] davinci_emac: conditionally compile specific PHY support Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 04/13] arm926ejs: add noop implementation for dcache ops Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 05/13] davinci_emac: fix for running with dcache enabled Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 06/13] davinci_emac: hardcode 100Mbps for AM35xx and RMII Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 07/13] AM35xx: add EMAC support Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 08/13] AM3517: move AM3517 specific mux defines to generic header Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 09/13] nand_spl_simple: add support for software ECC Ilya Yanok
2011-11-29 18:42 ` Scott Wood
2011-11-28 16:37 ` [U-Boot] [PATCH 10/13] omap_gpmc: use SOFTECC in SPL if it's enabled Ilya Yanok
2011-11-29 18:43 ` Scott Wood
2011-11-28 16:37 ` [U-Boot] [PATCH 11/13] nand_spl_simple: store temp data at CONFIG_SPL_NAND_WORKSPACE Ilya Yanok
2011-11-29 18:43 ` Scott Wood
2011-11-30 8:06 ` Igor Grinberg
2011-12-07 9:06 ` Stefano Babic
2011-12-07 17:46 ` Ilya Yanok
2011-12-07 18:18 ` Scott Wood
2011-12-07 18:45 ` Wolfgang Denk
2011-12-07 19:05 ` Ilya Yanok
2011-12-07 19:07 ` Stefano Babic
2011-11-28 16:37 ` [U-Boot] [PATCH 12/13] ehci-omap: driver for EHCI host on OMAP3 Ilya Yanok
2011-11-28 16:37 ` [U-Boot] [PATCH 13/13] mcx: support for HTKW mcx board Ilya Yanok
2011-11-29 18:54 ` Tom Rini
2011-11-30 13:49 ` Andy Fleming
2011-11-30 14:24 ` Tom Rini
2011-11-30 18:41 ` Wolfgang Denk
2011-11-30 8:21 ` Igor Grinberg
2011-12-12 15:39 ` Ilya Yanok
2011-12-12 16:22 ` Tom Rini
2011-12-13 19:18 ` Ilya Yanok
2011-12-14 22:40 ` Tom Rini
2011-11-29 7:29 ` [U-Boot] [PATCH V3 00/13] Support " Igor Grinberg
2011-11-29 7:39 ` Ilya Yanok
2011-11-29 7:54 ` Igor Grinberg
-- strict thread matches above, loose matches on Subject: below --
2011-11-11 0:39 [U-Boot] [PATCH v2 " Ilya Yanok
2011-11-11 0:39 ` [U-Boot] [PATCH 01/13] davinci_emac: move arch-independent defines to separate header Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDFFB61.6020006@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.