From: Yinghai Lu <yinghai.lu@oracle.com>
To: Peter Jones <pjones@redhat.com>,
Konrad Rzeszutek Wilk <konrad@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] ibft: Fix finding ibft with ACPI tables
Date: Thu, 08 Dec 2011 00:22:19 -0800 [thread overview]
Message-ID: <4EE073BB.6080403@oracle.com> (raw)
Found one system with UEFI/iBFT is not detected.
the root cause: for x86, We move calling of find_ibft_region() much earlier.
in setup_arch() before ACPI is enabled.
Try to all find_ibft_region() second times in ibft_init()
at that time ACPI iBFT already get permanent mapped with ioremap.
So isa_virt_to_bus will get wrong phys from right virt address.
We could just skip that printing.
For legacy one, print the found address early.
Signed-off-by: Yinghai Lu <yinghai.lu@kernel.org>
---
drivers/firmware/iscsi_ibft.c | 18 +++++++++++++++---
drivers/firmware/iscsi_ibft_find.c | 1 +
2 files changed, 16 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/firmware/iscsi_ibft.c
===================================================================
--- linux-2.6.orig/drivers/firmware/iscsi_ibft.c
+++ linux-2.6/drivers/firmware/iscsi_ibft.c
@@ -753,9 +753,21 @@ static int __init ibft_init(void)
{
int rc = 0;
+ /* find that from acpi tables */
+ if (!ibft_addr) {
+ unsigned long size = 0;
+
+ find_ibft_region(&size);
+ barrier();
+ }
+
if (ibft_addr) {
- printk(KERN_INFO "iBFT detected at 0x%llx.\n",
- (u64)isa_virt_to_bus(ibft_addr));
+ /*
+ * Second try is from acpi permanent map with ioremap
+ * can not simply convert back to phys addr.
+ * and We don't need to print that table phys addr.
+ */
+ pr_info("iBFT detected.\n");
rc = ibft_check_device();
if (rc)
@@ -770,7 +782,7 @@ static int __init ibft_init(void)
if (rc)
goto out_free;
} else
- printk(KERN_INFO "No iBFT detected.\n");
+ pr_info("No iBFT detected.\n");
return 0;
Index: linux-2.6/drivers/firmware/iscsi_ibft_find.c
===================================================================
--- linux-2.6.orig/drivers/firmware/iscsi_ibft_find.c
+++ linux-2.6/drivers/firmware/iscsi_ibft_find.c
@@ -94,6 +94,7 @@ static int __init find_ibft_in_mem(void)
* the table cannot be valid. */
if (pos + len <= (IBFT_END-1)) {
ibft_addr = (struct acpi_table_ibft *)virt;
+ pr_info("iBFT found at 0x%lx.\n", pos);
goto done;
}
}
next reply other threads:[~2011-12-08 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 8:22 Yinghai Lu [this message]
2011-12-08 14:29 ` [PATCH] ibft: Fix finding ibft with ACPI tables Konrad Rzeszutek Wilk
2011-12-08 15:01 ` Peter Jones
2011-12-08 16:51 ` Yinghai Lu
2011-12-08 16:52 ` [PATCH -v2] ibft: Fix finding IBFT ACPI table on UEFI Yinghai Lu
2011-12-08 19:08 ` Konrad Rzeszutek Wilk
2011-12-08 21:16 ` Yinghai Lu
2011-12-08 21:17 ` [PATCH -v3] " Yinghai Lu
2011-12-12 17:17 ` Konrad Rzeszutek Wilk
2011-12-12 20:39 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE073BB.6080403@oracle.com \
--to=yinghai.lu@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.