All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	linux-media@vger.kernel.org, mchehab@redhat.com,
	m.szyprowski@samsung.com, jonghun.han@samsung.com,
	riverful.kim@samsung.com, sw0312.kim@samsung.com,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2 1/2] v4l: Add new alpha component control
Date: Thu, 08 Dec 2011 13:30:37 +0100	[thread overview]
Message-ID: <4EE0ADED.6030109@samsung.com> (raw)
In-Reply-To: <201112081130.37875.laurent.pinchart@ideasonboard.com>

Hi Laurent,

On 12/08/2011 11:30 AM, Laurent Pinchart wrote:
>> Another use case for control range update would be with an auto-exposure
>> metering spot location controls. An available range for x and y coordinates
>> would depend on selected pixel resolution. If we would have created two
>> controls for (x, y) their range would depend on pixel (width, height)
>> respectively. So when a new format is set such controls would need to get
>> their range updated.
> 
> To be honest I'm not sure whether points, and especially rectangles, should be 
> handled as controls. We have no structure-like control type at the moment, 
> adding points might be possible, but rectangles would require either 2 point-
> liek controls or 4 controls (left, top, width, height). I don't really like 
> that. A new API (possibly based on the selection API ?) might be better.

Indeed, I don't like having 4 controls for specifying a rectangle as well, it
doesn't just sound right. I was concerned about specifying a point using
the selection API. But it could be just (left=x, top=y, width=1, height=1).


--
Regards,
Sylwester

  reply	other threads:[~2011-12-08 12:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-25 15:39 [PATCH/RFC v2] Add new V4L2_CID_ALPHA_COMPONENT control Sylwester Nawrocki
2011-11-25 15:39 ` [PATCH v2 1/2] v4l: Add new alpha component control Sylwester Nawrocki
2011-11-28 11:09   ` Laurent Pinchart
2011-11-28 11:38   ` Hans Verkuil
2011-11-28 12:13     ` Sylwester Nawrocki
2011-11-28 12:39       ` Hans Verkuil
2011-11-28 13:02         ` Sylwester Nawrocki
2011-11-29 11:08           ` Hans Verkuil
2011-11-29 16:40             ` Sylwester Nawrocki
2011-11-29 18:10               ` Laurent Pinchart
2011-11-29 18:30                 ` Hans Verkuil
2011-11-29 18:58                   ` Laurent Pinchart
2011-12-08  9:30                     ` Sylwester Nawrocki
2011-12-08 10:30                       ` Laurent Pinchart
2011-12-08 12:30                         ` Sylwester Nawrocki [this message]
2011-12-13 12:18                       ` Hans Verkuil
2011-12-14 13:34                         ` Sylwester Nawrocki
2011-12-14 14:42                           ` [PATCH/RFC v4 0/2] Add new V4L2_CID_ALPHA_COMPONENT control Sylwester Nawrocki
2011-12-14 14:42                             ` [PATCH v4 1/2] v4l: Add new alpha component control Sylwester Nawrocki
2011-12-14 14:42                             ` [PATCH v4 2/2] s5p-fimc: Add support for alpha component configuration Sylwester Nawrocki
2011-12-14 14:53                           ` [PATCH v2 1/2] v4l: Add new alpha component control Hans Verkuil
2011-11-29 19:39                 ` Sylwester Nawrocki
2011-11-30  1:40                   ` Laurent Pinchart
2011-11-25 15:39 ` [PATCH v2 2/2] s5p-fimc: Add support for alpha component configuration Sylwester Nawrocki
2011-11-28 11:42   ` Hans Verkuil
2011-11-28 12:17     ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE0ADED.6030109@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=hverkuil@xs4all.nl \
    --cc=jonghun.han@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@redhat.com \
    --cc=riverful.kim@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.