Re: [RFC PATCH 1/1]PCI: defer enablement of SRIOV BARS

[Don Dutile <ddutile@redhat.com>]

On 12/07/2011 09:50 PM, Ram Pai wrote:
> On Wed, Dec 07, 2011 at 03:11:56PM -0800, Yinghai Lu wrote:
>> On Wed, Dec 7, 2011 at 12:23 PM, Don Dutile<ddutile@redhat.com>  wrote:
>>> why not something more explicit like:
>>>
>>>         for (i = 0; i<  DEVICE_COUNT_RESOURCE; i++) {
>>>                 if ((i>=  PCI_IOV_RESOURCES)&&  (i<= PCI_IOV_RESOURCE_END))
>>>                         continue; /* skip sriov related resources */
>>>
>>>                 if (dev->resource[i].flags&  flags)
>>>                         bars |= (1<<  i);
>>>         }
>
> I like this approach too. Offcourse the SRIOV skipping has to be one under #ifdef CONFIG_PCI_IOV.
>
+1. Sorry, I forgot that the kernel can be built w/o SRIOV support.


> Yinghai/Jesse, do you want to make a patch on top of the current jesse's to-linus
> tree or want to revert my patch and apply your fix? If it is the former, do you want me
> to make the patch?
>
> RP
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html