All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Philipp Dreimann <philipp@dreimann.net>,
	linux-wireless@vger.kernel.org, mikem@ring3k.org,
	John Linville <linville@tuxdriver.com>
Subject: Re: rtlwifi, rtl8192se bug soft-lockup
Date: Thu, 08 Dec 2011 11:26:26 -0600	[thread overview]
Message-ID: <4EE0F342.6040105@lwfinger.net> (raw)
In-Reply-To: <20111208095212.GB2402@redhat.com>

On 12/08/2011 03:52 AM, Stanislaw Gruszka wrote:
> On Wed, Dec 07, 2011 at 06:47:58PM -0200, Philipp Dreimann wrote:
>> No, this was not posted so far. I will try to debug the loop issue
>> soonish. The outlined idea above only prevents the issue without
>> knowing what is happening.
>
> I looked at it a bit more and realized that we can replace spinlock
> by mutex. This should fix remaining problems here, and hopefully do
> not introduce any others. Could you test two attached patches, and
> if they do not crash intermediately :-) retest again with
> CONFIG_LOCKDEP ?

After about 1 hour of testing, I see no problems and no lockdep warnings.

BTW, patch #2 did not apply to wireless-testing as your previous patch changing 
the locking in ps.c has already been applied. Fortunately, it was not much of a 
problem to get it applied using wiggle.

Larry


      reply	other threads:[~2011-12-08 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29  0:58 rtlwifi, rtl8192se bug soft-lockup Philipp Dreimann
2011-11-29  2:16 ` Larry Finger
2011-12-07 13:59   ` Philipp Dreimann
2011-12-07 17:23     ` Larry Finger
2011-12-07 20:47       ` Philipp Dreimann
2011-12-07 21:09         ` Larry Finger
2011-12-08  9:52         ` Stanislaw Gruszka
2011-12-08 17:26           ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE0F342.6040105@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mikem@ring3k.org \
    --cc=philipp@dreimann.net \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.