Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci

[hkran <hkran@linux.vnet.ibm.com>]

On 12/08/2011 10:30 AM, Anthony Liguori wrote:
> On 12/07/2011 03:39 AM, hkran wrote:
>> Signed-off-by: hkran <hkran@linux.vnet.ibm.com>
>
> A Signed-off-by line needs to use your full name.
>
> Regards,
>
> Anthony Liguori
>
>> ---
>> hw/virtio-pci.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
>> index c665f5c..f8ee772 100644
>> --- a/hw/virtio-pci.c
>> +++ b/hw/virtio-pci.c
>> @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, 
>> VirtIODevice *vdev)
>> if (proxy->class_code) {
>> pci_config_set_class(config, proxy->class_code);
>> }
>> - pci_set_word(config + 0x2c, pci_get_word(config + PCI_VENDOR_ID));
>> - pci_set_word(config + 0x2e, vdev->device_id);
>> - config[0x3d] = 1;
>> + pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config +
>> PCI_VENDOR_ID));
>> + pci_set_word(config + PCI_SUBSYSTEM_ID, vdev->device_id);
>> + config[PCI_INTERRUPT_PIN] = 1;
>>
>> memory_region_init(&proxy->msix_bar, "virtio-msix", 4096);
>> if (vdev->nvectors && !msix_init(&proxy->pci_dev, vdev->nvectors,
>
Signed-off-by: Hui Kai Ran <hkran@linux.vnet.ibm.com>