All of lore.kernel.org
 help / color / mirror / Atom feed
From: annie li <annie.li@oracle.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: annie li <annie.li@oracle.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"jeremy@goop.org" <jeremy@goop.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>
Subject: Re: [PATCH V2 1/2] xen/granttable: Support sub-page grants
Date: Fri, 09 Dec 2011 15:45:02 +0800	[thread overview]
Message-ID: <4EE1BC7E.3060904@oracle.com> (raw)
In-Reply-To: <4EE19A4D.9030500@oracle.com>



On 2011-12-9 13:19, annie li wrote:
> Hi Paul,
>
>>>> #define get_free_entry()    get_free_entries(1)
> Is this necessary? Maybe you defined this to keep consistence with 
> put_free_entry(ref)?
> But other functions such as gnttab_grant_foreign_transfer and 
> gnttab_grant_foreign_access all call get_free_entries(1). Maybe it is 
> better to keep initial get_free_entries(1) code?
Another approach is doing those work in a separate patch -- changing 
get_free_entries to get_free_entry in following 4 functions:
gnttab_grant_foreign_access
gnttab_grant_foreign_access_subpage
gnttab_grant_foreign_access_trans
gnttab_grant_foreign_transfer

Thanks
Annie

  reply	other threads:[~2011-12-09  7:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08  9:35 [PATCH V2 0/2] xen: patches for supporting sub-page and transitive grants annie.li
2011-12-08  9:37 ` [PATCH V2 1/2] xen/granttable: Support sub-page grants annie.li
2011-12-08  9:49   ` Paul Durrant
2011-12-08 10:01     ` ANNIE LI
2011-12-08 10:04       ` Paul Durrant
2011-12-08 13:46         ` annie li
2011-12-09  5:19         ` annie li
2011-12-09  7:45           ` annie li [this message]
2011-12-09  8:37             ` Ian Campbell
2011-12-09  8:48               ` Paul Durrant
2011-12-09  8:48                 ` Paul Durrant
2011-12-09 11:27                 ` annie li
2011-12-08  9:37 ` [PATCH V2 2/2] xen/granttable: Support transitive grants annie.li
2011-12-08  9:51   ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE1BC7E.3060904@oracle.com \
    --to=annie.li@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.