Re: [PATCH 3/3] staging:iio: Fix scan mask update

[Lars-Peter Clausen <lars@metafoo.de>]

On 12/08/2011 09:18 PM, Greg KH wrote:
> On Thu, Dec 08, 2011 at 06:35:53PM +0100, Lars-Peter Clausen wrote:
>> When updating the scan mask we have to check the actual scan mask fo=
r if the
>> channel is already enabled, not the matching scan mask from the avai=
lable
>> scan masks. The bit will already be set there and as a result the ac=
tual
>> scan mask will not get updated and the channel stays disabled.
>>
>> Also fix the return value of iio_scan_el_store which would return 1 =
instead of
>> the number of bytes written if the channel was already active in the=
 scan mask.
>=20
> You just added a complier warning with this patch:
>   CC [M]  drivers/staging/iio/industrialio-buffer.o
> drivers/staging/iio/industrialio-buffer.c: In function =E2=80=98iio_s=
can_mask_query=E2=80=99:
> drivers/staging/iio/industrialio-buffer.c:621:8: warning: unused vari=
able =E2=80=98mask=E2=80=99 [-Wunused-variable]
>=20
> So I didn't apply it.

Actually you did. At least it is in staging-next. Should I resend a upd=
ated
patch or just a patch removing the now unused mask variable.

Thanks,
- Lars