All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: r66093@freescale.com
Cc: linux-mmc@vger.kernel.org, Jerry Huang <Chang-Ming.Huang@freescale.com>
Subject: Re: [PATCH 2/4] MMC/SD: Add callback function to detect card
Date: Fri, 09 Dec 2011 12:03:23 +0200	[thread overview]
Message-ID: <4EE1DCEB.5030102@intel.com> (raw)
In-Reply-To: <1323077026-12071-2-git-send-email-r66093@freescale.com>

On 05/12/11 11:23, r66093@freescale.com wrote:
> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> 
> In order to check whether the card has been removed, the function
> mmc_send_status() will send command CMD13 to card and ask the card
> to send its status register to sdhc driver, which will generate
> many interrupts repeatedly and make the system performance bad.

That should not be true.  sdhci.c will not send a command to the
card if the card is not present i.e. see this excerpt from
sdhci_request():


	/* If polling, assume that the card is always present. */
	if (host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION)
		present = true;
	else
		present = sdhci_readl(host, SDHCI_PRESENT_STATE) &
				SDHCI_CARD_PRESENT;

	if (!present || host->flags & SDHCI_DEVICE_DEAD) {
		host->mrq->cmd->error = -ENOMEDIUM;
		tasklet_schedule(&host->finish_tasklet);

  parent reply	other threads:[~2011-12-09 10:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05  9:23 [PATCH 1/4] SDHCI: add sdhci_get_cd callback to detect the card r66093
2011-12-05  9:23 ` [PATCH 2/4] MMC/SD: Add callback function to detect card r66093
2011-12-05  9:23   ` [PATCH 3/4] MMC/core: Make sure the power is up, when detect the card r66093
2011-12-05  9:23     ` [PATCH 4/4] MMC/core: Add f_min to mmc_power_on() r66093
2011-12-05 15:48     ` [PATCH 3/4] MMC/core: Make sure the power is up, when detect the card Ulf Hansson
2011-12-06  5:40       ` Huang Changming-R66093
2011-12-07  9:04     ` Linus Walleij
2011-12-09  3:16       ` Huang Changming-R66093
2011-12-09 10:03   ` Adrian Hunter [this message]
2011-12-13  7:25     ` [PATCH 2/4] MMC/SD: Add callback function to detect card Huang Changming-R66093
2011-12-13  8:01       ` Adrian Hunter
2011-12-13  8:26         ` Huang Changming-R66093
2011-12-13  8:54           ` Adrian Hunter
2011-12-13  9:55             ` Huang Changming-R66093
2011-12-13 10:26               ` Adrian Hunter
2011-12-14  2:21                 ` Huang Changming-R66093
2011-12-05 11:25 ` [PATCH 1/4] SDHCI: add sdhci_get_cd callback to detect the card Dong, Chuanxiao
2011-12-06  5:43   ` Huang Changming-R66093
2011-12-05 18:48 ` Philip Rakity
2011-12-06  5:35   ` Huang Changming-R66093
2011-12-13 18:06   ` Chris Ball
2011-12-14  2:31     ` Huang Changming-R66093

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE1DCEB.5030102@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Chang-Ming.Huang@freescale.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=r66093@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.