Re: [PATCH] cdmamodem: Disable dormant mode at initialization

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Hi Guillaume,

On 12/09/2011 05:04 AM, Guillaume Zajac wrote:
> ---
>  drivers/cdmamodem/connman.c |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/cdmamodem/connman.c b/drivers/cdmamodem/connman.c
> index c03841e..61573ff 100644
> --- a/drivers/cdmamodem/connman.c
> +++ b/drivers/cdmamodem/connman.c
> @@ -276,6 +276,20 @@ static void at_c0_cb(gboolean ok, GAtResult *result, gpointer user_data)
>  	ofono_cdma_connman_register(cm);
>  }
>  
> +static void at_cta0_cb(gboolean ok, GAtResult *result, gpointer user_data)
> +{
> +	struct ofono_cdma_connman *cm = user_data;
> +
> +	DBG("ok %d", ok);
> +
> +	if (ok == FALSE) {
> +		ofono_info("Unable to configure Dormant mode");
> +		return;
> +	}
> +
> +	ofono_cdma_connman_dormant_notify(cm, FALSE);
> +}
> +

The core atom will default to FALSE here anyway, so I see no need in
this callback, so I pushed a much simplified patch upstream.

>  static int cdma_connman_probe(struct ofono_cdma_connman *cm,
>  					unsigned int vendor, void *data)
>  {
> @@ -300,6 +314,7 @@ static int cdma_connman_probe(struct ofono_cdma_connman *cm,
>  	ofono_cdma_connman_set_data(cm, cd);
>  
>  	g_at_chat_send(cd->chat, "AT&C0", none_prefix, at_c0_cb, cm, NULL);
> +	g_at_chat_send(cd->chat, "AT+CTA=0", none_prefix, at_cta0_cb, cm, NULL);
>  
>  	return 0;
>  }

Regards,
-Denis