From: John Fastabend <john.r.fastabend@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [net-next PATCH] net: netprio_cgroup: make net_prio_subsys static
Date: Fri, 09 Dec 2011 08:31:59 -0800 [thread overview]
Message-ID: <4EE237FF.20409@intel.com> (raw)
In-Reply-To: <1323446704.2336.20.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On 12/9/2011 8:05 AM, Eric Dumazet wrote:
> Le jeudi 08 décembre 2011 à 19:53 -0500, David Miller a écrit :
>> From: Neil Horman <nhorman@tuxdriver.com>
>> Date: Thu, 8 Dec 2011 06:45:55 -0500
>>
>>> On Wed, Dec 07, 2011 at 09:17:17PM -0800, John Fastabend wrote:
>>>> net_prio_subsys can be made static this removes the sparse
>>>> warning it was throwing.
>>>>
>>>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>> ...
>>> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>>
>> Applied.
>> --
>
> But it trivialy breaks the build ? Or am I mistaken ?
>
Dang. No your right. When its not built as a module it breaks. Sorry
I'll revert it.
>
> $ grep CONFIG_NETPRIO_CGROUP .config
> CONFIG_NETPRIO_CGROUP=y
>
> $ make net/core/netprio_cgroup.o
> CC net/core/netprio_cgroup.o
> net/core/netprio_cgroup.c:31:29: error: static declaration of ‘net_prio_subsys’ follows non-static declaration
> include/linux/cgroup_subsys.h:71:1: note: previous declaration of ‘net_prio_subsys’ was here
> make[1]: *** [net/core/netprio_cgroup.o] Error 1
> make: *** [net/core/netprio_cgroup.o] Error 2
>
>
>
next prev parent reply other threads:[~2011-12-09 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 5:17 [net-next PATCH] net: netprio_cgroup: make net_prio_subsys static John Fastabend
2011-12-08 11:45 ` Neil Horman
2011-12-09 0:53 ` David Miller
2011-12-09 16:05 ` Eric Dumazet
2011-12-09 16:31 ` John Fastabend [this message]
2011-12-09 16:40 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE237FF.20409@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.