From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] scripts/send-pull-request: allow sending of patches without a cover letter
Date: Fri, 09 Dec 2011 11:45:49 -0800 [thread overview]
Message-ID: <4EE2656D.7090706@linux.intel.com> (raw)
In-Reply-To: <CAP9ODKrH8hZ=fiD82vJMMopJ1grKEcZw07pPy7a1PNFtb_gq0w@mail.gmail.com>
On 12/09/2011 11:36 AM, Otavio Salvador wrote:
> On Fri, Dec 9, 2011 at 17:34, Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>> wrote:
>
> why do you want to avoid cover letter ? or is it for other layers
> other than oe-core
>
>
> When it is a single patch makes no sense to send a cover letter that
> most of time we just write the same of first commit.
Well, you could just use git-send-email when there is only 1 patch. I
had considered having the tool create only a single email if there was
only 1 patch. However, in the end, I just send the cover letter with the
pull requrest and let the single patch follow. It works fine and is
consistent with the other patches, even if it is a degenerate case.
So I don't think this is necessary really, but if it works for you and
doesn't get abused, I'm fine with it. Perhaps only allowing this if
there is indeed only 1 patch would be better.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2011-12-09 19:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 15:40 [PATCH 0/3] Misc fixes/improvements Otavio Salvador
2011-12-08 15:40 ` [PATCH 1/3] cross.bbclass: add virtclass handler Otavio Salvador
2011-12-08 22:09 ` Richard Purdie
2012-02-07 19:28 ` Otavio Salvador
2011-12-08 15:40 ` [PATCH 2/3] dosfstools: update native to 2.11 Otavio Salvador
2011-12-09 19:08 ` Kamble, Nitin A
2011-12-09 19:15 ` Darren Hart
2011-12-09 19:17 ` Otavio Salvador
2011-12-09 19:21 ` Darren Hart
2011-12-09 19:35 ` Otavio Salvador
2011-12-09 19:42 ` Darren Hart
2011-12-12 23:15 ` Saul Wold
2011-12-13 15:49 ` Richard Purdie
2011-12-08 15:40 ` [PATCH 3/3] scripts/send-pull-request: allow sending of patches without a cover letter Otavio Salvador
2011-12-09 19:18 ` Darren Hart
2011-12-10 0:07 ` Richard Purdie
2011-12-10 15:51 ` Otavio Salvador
2011-12-09 19:34 ` Khem Raj
2011-12-09 19:36 ` Otavio Salvador
2011-12-09 19:45 ` Darren Hart [this message]
2011-12-09 19:48 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE2656D.7090706@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.