From: Mauro Carvalho Chehab <maurochehab@gmail.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Manu Abraham <abraham.manu@gmail.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: v4 [PATCH 09/10] CXD2820r: Query DVB frontend delivery capabilities
Date: Sat, 10 Dec 2011 10:47:22 -0200 [thread overview]
Message-ID: <4EE354DA.6060006@gmail.com> (raw)
In-Reply-To: <4EE346E0.7050606@iki.fi>
On 10-12-2011 09:47, Antti Palosaari wrote:
> Hello Manu,
> That patch looks now much acceptable than the older for my eyes, since you removed that .set_state() (change from .set_params() to .set_state()) I criticized. Thanks!
>
>
> On 12/10/2011 06:44 AM, Manu Abraham wrote:
>> static int cxd2820r_set_frontend(struct dvb_frontend *fe,
> [...]
>> + switch (c->delivery_system) {
>> + case SYS_DVBT:
>> + ret = cxd2820r_init_t(fe);
>
>> + ret = cxd2820r_set_frontend_t(fe, p);
>
>
> Anyhow, I don't now like idea you have put .init() calls to .set_frontend(). Could you move .init() happen in .init() callback as it was earlier?
Changing .init() to happen at set_frontend() actually makes sense for me ;)
Why didn't you like this change?
Regards,
Mauro
next prev parent reply other threads:[~2011-12-10 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 4:44 v4 [PATCH 09/10] CXD2820r: Query DVB frontend delivery capabilities Manu Abraham
2011-12-10 11:47 ` Antti Palosaari
2011-12-10 12:47 ` Mauro Carvalho Chehab [this message]
2011-12-10 13:09 ` Antti Palosaari
2011-12-10 13:18 ` Mauro Carvalho Chehab
2011-12-12 4:28 ` Manu Abraham
2011-12-12 12:43 ` Andreas Oberritter
2011-12-12 12:55 ` Manu Abraham
2011-12-12 13:41 ` Antti Palosaari
2011-12-12 13:57 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE354DA.6060006@gmail.com \
--to=maurochehab@gmail.com \
--cc=abraham.manu@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.